From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765740AbdEXBam convert rfc822-to-8bit (ORCPT ); Tue, 23 May 2017 21:30:42 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:36378 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760577AbdEXBaj (ORCPT ); Tue, 23 May 2017 21:30:39 -0400 X-AuditID: b6c32a37-f79f46d000003503-4e-5924e23c358f Mime-Version: 1.0 Subject: RE: Re: [PATCH v1] PM / devfreq: exynos-ppmu : Handle return value of clk_prepare_enable Reply-To: myungjoo.ham@samsung.com From: MyungJoo Ham To: Chanwoo Choi , Arvind Yadav , Kyungmin Park , "krzk@kernel.org" , "kgene@kernel.org" , "javier@osg.samsung.com" CC: "linux-pm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: <592403E7.8060906@samsung.com> X-Drm-Type: N,general X-EPLocale: ko_KR.EUC-KR X-EPWebmail-Msg-Type: personal X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Illegal-Object: Syntax error in X-Sender: address found on vger.kernel.org: X-Sender: =?utf-8?B?U2Ftc3VuZyBFbGVjdHJvbmljcxtGcm9udGll?= ^-Extraneous program text X-Sender-IP: 10.113.63.113 X-Local-Sender: =?UTF-8?B?7ZWo66qF7KO8G0Zyb250aWVyIENTIExhYihTL1fshLzthLApG+yCvOyEsQ==?= =?UTF-8?B?7KCE7J6QG1ByaW5jaXBhbCBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TXl1bmdKb28gSGFtG0Zyb250aWVyIENTIExhYi4bU2Ftc3VuZyBFbGVj?= =?UTF-8?B?dHJvbmljcxtQcmluY2lwYWwgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwGxtDMTBWODEwNA==?= Message-ID: <20170524013036epcms1p3f5ced11e6ebe5664ce70718dedcf8de1@epcms1p3> Date: Wed, 24 May 2017 01:30:36 +0000 X-CMS-MailID: 20170524013036epcms1p3f5ced11e6ebe5664ce70718dedcf8de1 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" X-MTR: 20170524013036epcms1p3f5ced11e6ebe5664ce70718dedcf8de1 CMS-TYPE: 101P X-Brightmail-Tracker: H4sIAAAAAAAAA01Se0hTcRTmt7vd3UmrX0vtZGBysyjFzTunXksrSGKQllHQu3WbF7X2anf2 IkiE6J0VVmsVZUmFWZPlK+3FKoOytAcue8hM7GUPehFGRXe7i/rvO9/vO+f7zo9DEZoTZBxV YnPxThtnockoeeP1ibqU7BeJC1PP16exXbuqCDbw9ZWCffe+VsZW9A0QbEdHnZK9W/5Oyfr6 uhTsw5YjJPtl1w3EujuuyKZFGS96niuNvpptpPFC9SZjfYVY7a6vQcYvvvgCchGfXcxzhbwz gbeZ7YUltqIceuZc03RTekYqk8JksZl0go2z8jl0bl5ByowSi5iMTljDWUpFqoATBFo3Jdtp L3XxCcV2wZVDL2YYvZZJzdTq9XqtIW3pJH26KFnOF1+uVDsCeN3DN3tlZego3o5UFGADBN72 IwnHQmePl9yOoigNbkbQV1EuPlCUGg+HX80jQpoR2AwPnjSF9RpMQ1n3FULidbA12BjmSZwC DXXP5aE50bhcBp/a78tCBYHdMjjjaSQlNzW4t/TLJTwamk43hLtVOBl8gxcjfAx0n32vlDDA s4FOmYTj4cC3WuKv5mPbscgG0bC5526EHw7BwdYIvxq8JwfloWUAx0HAvyyUB/AOBO7qWwqp 2Irg3s/vEQMdXN3XGw6hxvlQWekND5LjcXC0+1HEIBcCDTVhPSGGPlU1QIQMCDwRvC06SZID ZZeuKyXJUPjwbadC4seDv7VauQclev79r+e/QZ5/g44jogbF8g7BWsQLjCNNK3BWodRWpDXb rT4Uvs+kzGZUdy/PjzCF6CHqzvmJCzUKbo2w3upHQBF0tPp0nUipC7n1G3in3eQstfCCH6WL ++wl4mLMdvHabS4TY8hKNWToxZPLYhh6pDrW27VAg4s4F7+K5x2882+fjFLFlaFZQ5ra72iC Xx+vW6E6l/z7mOp2TCu1pG/q59r8oScmG9sEXZIlOWggZ+2+dmCM7+PJaRPyOc/Tee3D1o5T 9ZjmOH1dhyyOnsHXhw/2xp8d+/icOXZF5g93/+zW3BveID1miv2XLr73rXVUW71rwbI3r2+u haqXTOLxjfubVi5pac8QaLlQzDFJhFPg/gA4cy0ttQMAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170519105745epcas5p29a5cbb259cd15138d7220f34e130e00a X-RootMTR: 20170519105745epcas5p29a5cbb259cd15138d7220f34e130e00a References: <592403E7.8060906@samsung.com> <1495191364-16015-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 2017년 05월 19일 19:56, Arvind Yadav wrote: > > clk_prepare_enable() can fail here and we must check its return value. > > > > Signed-off-by: Arvind Yadav > > --- > > drivers/devfreq/event/exynos-ppmu.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c > > index 9b73509..8f6537a 100644 > > --- a/drivers/devfreq/event/exynos-ppmu.c > > +++ b/drivers/devfreq/event/exynos-ppmu.c > > @@ -648,7 +648,11 @@ static int exynos_ppmu_probe(struct platform_device *pdev) > > dev_name(&pdev->dev), desc[i].name); > > } > > > > - clk_prepare_enable(info->ppmu.clk); > > + ret = clk_prepare_enable(info->ppmu.clk); > > + if (ret) { > > + dev_err(&pdev->dev, "failed to prepare ppmu clock\n"); > > + return ret; > > + } > > You're right. But, actually, some ppmu device-tree node doesn't include > the clock information because exynos clk driver don't support the > clock for some ppmu devices. Until now, the clock of ppmu devices > are default on state. If it does not include the clock information, info->ppmu.clk is NULL, which makes ret == NULL, so this should be ok. (Line 593 of this file does that.) Acked-by: MyungJoo Ham (Applied to next-rc in devfreq tree) (same applies to exynos-nocp commit as well) Cheers, MyungJoo