From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966705AbdEXICB (ORCPT ); Wed, 24 May 2017 04:02:01 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:27061 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966604AbdEXIB6 (ORCPT ); Wed, 24 May 2017 04:01:58 -0400 From: Christophe Leroy Subject: [PATCH] powerpc: sysdev: simple_gpio: fix Oops in gpio save_regs function To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Scott Wood , Linus Walleij Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-gpio@vger.kernel.org, stable@vger.kernel.org Message-Id: <20170524080156.1C4936EB78@pc13941vm.idsi0.si.c-s.fr> Date: Wed, 24 May 2017 10:01:55 +0200 (CEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_mm_gpiochip_add_data() generates an Oops for NULL pointer dereference. of_mm_gpiochip_add_data() calls mm_gc->save_regs() before setting the data, therefore ->save_regs() cannot use gpiochip_get_data() Fixes: 937daafca774b ("powerpc: simple-gpio: use gpiochip data pointer") Cc: stable@vger.kernel.org Signed-off-by: Christophe Leroy --- arch/powerpc/sysdev/simple_gpio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/sysdev/simple_gpio.c b/arch/powerpc/sysdev/simple_gpio.c index ef470b470b04..6afddae2fb47 100644 --- a/arch/powerpc/sysdev/simple_gpio.c +++ b/arch/powerpc/sysdev/simple_gpio.c @@ -75,7 +75,8 @@ static int u8_gpio_dir_out(struct gpio_chip *gc, unsigned int gpio, int val) static void u8_gpio_save_regs(struct of_mm_gpio_chip *mm_gc) { - struct u8_gpio_chip *u8_gc = gpiochip_get_data(&mm_gc->gc); + struct u8_gpio_chip *u8_gc = + container_of(mm_gc, struct u8_gpio_chip, mm_gc); u8_gc->data = in_8(mm_gc->regs); } -- 2.12.0