From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161365AbdEXIke (ORCPT ); Wed, 24 May 2017 04:40:34 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:39673 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762584AbdEXIkS (ORCPT ); Wed, 24 May 2017 04:40:18 -0400 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.wolfsonmicro.com Date: Wed, 24 May 2017 09:41:14 +0100 From: Charles Keepax To: "Gustavo A. R. Silva" CC: Lee Jones , , Subject: Re: [PATCH] mfd: add null check before pointer dereference Message-ID: <20170524084114.GP1594@localhost.localdomain> References: <20170524031933.Horde.wa-QkL1FV1tHTUxWqYOd-Ym@gator4166.hostgator.com> <20170524082731.GA25027@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170524082731.GA25027@embeddedgus> User-Agent: Mutt/1.5.23 (2014-03-12) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705240041 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2017 at 03:27:31AM -0500, Gustavo A. R. Silva wrote: > Add null check before dereferencing pointer of_id in order to avoid > a potential NULL pointer dereference. > > Addresses-Coverity-ID: 1408830 > Cc: Charles Keepax > Signed-off-by: Gustavo A. R. Silva > --- Acked-by: Charles Keepax Looks good although is there not probably the same issue in wm831x-i2c.c? Might be worth fixing up both of them. Thanks, Charles