From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937087AbdEXInZ (ORCPT ); Wed, 24 May 2017 04:43:25 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:38419 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936919AbdEXInU (ORCPT ); Wed, 24 May 2017 04:43:20 -0400 Date: Wed, 24 May 2017 09:43:17 +0100 From: Lee Jones To: "Gustavo A. R. Silva" Cc: Charles Keepax , patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: add null check before pointer dereference Message-ID: <20170524084317.6fpuedrepvnj62ch@dell> References: <20170524031933.Horde.wa-QkL1FV1tHTUxWqYOd-Ym@gator4166.hostgator.com> <20170524082731.GA25027@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170524082731.GA25027@embeddedgus> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please use the $SUBJECT line expected by the subsystem. The following command can help with this: `git log --oneline -- ` > Add null check before dereferencing pointer of_id in order to avoid > a potential NULL pointer dereference. > > Addresses-Coverity-ID: 1408830 > Cc: Charles Keepax > Signed-off-by: Gustavo A. R. Silva > --- > drivers/mfd/wm831x-spi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mfd/wm831x-spi.c b/drivers/mfd/wm831x-spi.c > index c332e28..7b227c9 100644 > --- a/drivers/mfd/wm831x-spi.c > +++ b/drivers/mfd/wm831x-spi.c > @@ -34,6 +34,10 @@ static int wm831x_spi_probe(struct spi_device *spi) > > if (spi->dev.of_node) { > of_id = of_match_device(wm831x_of_match, &spi->dev); > + if (!of_id) { > + dev_err(&spi->dev, "Failed to find matching id\n"); > + return -EINVAL; > + } I already mentioned why this isn't suitable. Please see my pre-review. > type = (enum wm831x_parent)of_id->data; > } else { > type = (enum wm831x_parent)id->driver_data; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog