From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1164030AbdEXMZA (ORCPT ); Wed, 24 May 2017 08:25:00 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34640 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763304AbdEXMY5 (ORCPT ); Wed, 24 May 2017 08:24:57 -0400 Date: Wed, 24 May 2017 14:24:51 +0200 From: Daniel Vetter To: CK Hu Cc: Daniel Vetter , Bibby Hsieh , David Airlie , Matthias Brugger , Daniel Vetter , "dri-devel@lists.freedesktop.org" , "linux-mediatek@lists.infradead.org" , Yingjoe Chen =?utf-8?B?KOmZs+iLsea0sik=?= , Cawa Cheng =?utf-8?B?KOmEreabhOempyk=?= , Daniel Kurtz , Philipp Zabel , YT Shen =?utf-8?B?KOayiOWys+mchik=?= , Thierry Reding , Mao Huang , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Sascha Hauer Subject: Re: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions Message-ID: <20170524122451.vc252rdphzwzljeu@phenom.ffwll.local> Mail-Followup-To: CK Hu , Bibby Hsieh , David Airlie , Matthias Brugger , "dri-devel@lists.freedesktop.org" , "linux-mediatek@lists.infradead.org" , Yingjoe Chen =?utf-8?B?KOmZs+iLsea0sik=?= , Cawa Cheng =?utf-8?B?KOmEreabhOempyk=?= , Daniel Kurtz , Philipp Zabel , YT Shen =?utf-8?B?KOayiOWys+mchik=?= , Thierry Reding , Mao Huang , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Sascha Hauer References: <1485234604-19889-1-git-send-email-bibby.hsieh@mediatek.com> <1495531695.20811.19.camel@mtksdaap41> <20170523131243.5bjz5n4uv73r2l7j@phenom.ffwll.local> <1495617645.15919.6.camel@mtksdaap41> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1495617645.15919.6.camel@mtksdaap41> X-Operating-System: Linux phenom 4.9.0-2-amd64 User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2017 at 05:20:45PM +0800, CK Hu wrote: > On Tue, 2017-05-23 at 15:12 +0200, Daniel Vetter wrote: > > On Tue, May 23, 2017 at 05:28:15PM +0800, CK Hu wrote: > > > Hi, Bibby: > > > > > > I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1, > > > thanks. > > > > > > Regards, > > > CK > > > > > > On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote: > > > > Current Mediatek DRM driver does not support interlaced mode, and > > > > will hang if such resolution is used: Filter those to prevent > > > > kernel hangs, until the DRM driver is fixed properly. > > > > > > > > Signed-off-by: Bibby Hsieh > > > > --- > > > > drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c > > > > index 0e8c4d9..e33678d 100644 > > > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c > > > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c > > > > @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn, > > > > return MODE_BAD; > > > > } > > > > > > > > + if (mode->flags & DRM_MODE_FLAG_INTERLACE) > > > > + return MODE_NO_INTERLACE; > > > > if (mode->clock < 27000) > > > > return MODE_CLOCK_LOW; > > > > if (mode->clock > 297000) > > > > You probably want to check out Jose's mode_valid work, since only > > filtering in the connector's ->mode_valid callback isn't enough. You also > > need to filter in ->mode_fixup (or some other place called at atomic_check > > time). > > -Daniel > > Hi, Daniel: > > Yes, I still need to filter in ->mode_fixup. > > Hi, Bibby: > > Because Jose's work plan to use mode_valid to replace mode_fixup, so > it's better to refine this patch after Jose's work is done. And I would > now remove this patch from my branch. Btw if you have a revised version of your patch on top of Jose's series, a tested-by on that would be awesome. The more people find it useful, the faster it will land. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch