From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S967368AbdEXOA5 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 24 May 2017 10:00:57 -0400
Received: from mailout2.hostsharing.net ([83.223.90.233]:38525 "EHLO
        mailout2.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965567AbdEXOAv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 24 May 2017 10:00:51 -0400
Date: Wed, 24 May 2017 16:00:49 +0200
From: Lukas Wunner <lukas@wunner.de>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andreas Noever <andreas.noever@gmail.com>,
        Michael Jamet <michael.jamet@intel.com>,
        Yehezkel Bernat <yehezkel.bernat@intel.com>,
        Amir Levy <amir.jer.levy@intel.com>, Andy Lutomirski <luto@kernel.org>,
        Mario.Limonciello@dell.com, Jared.Dominguez@dell.com,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/24] thunderbolt: Let the connection manager handle all
 notifications
Message-ID: <20170524140049.aaif5724kwfgs33e@wunner.de>
References: <20170518143914.60902-1-mika.westerberg@linux.intel.com>
 <20170518143914.60902-15-mika.westerberg@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170518143914.60902-15-mika.westerberg@linux.intel.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 18, 2017 at 05:39:04PM +0300, Mika Westerberg wrote:
> @@ -320,18 +330,42 @@ static void tb_ctl_rx_callback(struct tb_ring *ring, struct ring_frame *frame,
>  	}
>  
>  	frame->size -= 4; /* remove checksum */
> -	if (*(__be32 *) (pkg->buffer + frame->size)
> -			!= tb_crc(pkg->buffer, frame->size)) {
> -		tb_ctl_err(pkg->ctl,
> -			   "RX: checksum mismatch, dropping packet\n");
> -		goto rx;
> -	}
> +	crc32 = tb_crc(pkg->buffer, frame->size);
>  	be32_to_cpu_array(pkg->buffer, pkg->buffer, frame->size / 4);
>  
> -	if (frame->eof == TB_CFG_PKG_EVENT) {
> -		tb_ctl_handle_plug_event(pkg->ctl, pkg);
> +	switch (frame->eof) {
> +	case TB_CFG_PKG_READ:
> +	case TB_CFG_PKG_WRITE:
> +	case TB_CFG_PKG_ERROR:
> +	case TB_CFG_PKG_OVERRIDE:
> +	case TB_CFG_PKG_RESET:
> +		if (*(__be32 *)(pkg->buffer + frame->size) != crc32) {
> +			tb_ctl_err(pkg->ctl,
> +				   "RX: checksum mismatch, dropping packet\n");
> +			goto rx;
> +		}

Any harm keeping the crc32 check above the switch/case statement?
(And thus also execute it for unknown packets?)


> +	case TB_CFG_PKG_EVENT:
> +		if (*(__be32 *)(pkg->buffer + frame->size) != crc32) {
> +			tb_ctl_err(pkg->ctl,
> +				   "RX: checksum mismatch, dropping packet\n");
> +			goto rx;
> +		}
> +		tb_ctl_handle_event(pkg->ctl, frame->eof, pkg, frame->size);
> +		goto rx;
> +
> +	default:
> +		tb_ctl_dbg(pkg->ctl, "RX: unknown package %#x, dropping\n",

The packet / package terminology is a bit inconsistent here.
Andreas originally used package.  What's the term used by the TB spec?

Thanks,

Lukas