From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764881AbdEXObs (ORCPT ); Wed, 24 May 2017 10:31:48 -0400 Received: from mx2.suse.de ([195.135.220.15]:42535 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752136AbdEXObo (ORCPT ); Wed, 24 May 2017 10:31:44 -0400 Date: Wed, 24 May 2017 16:31:42 +0200 From: Michal Hocko To: Anshuman Khandual Cc: Vlastimil Babka , Christoph Hellwig , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Define KB, MB, GB, TB in core VM Message-ID: <20170524143142.GA14715@dhcp22.suse.cz> References: <20170522111742.29433-1-khandual@linux.vnet.ibm.com> <20170522141149.9ef84bb0713769f4af0383f0@linux-foundation.org> <20170523070227.GA27864@infradead.org> <09a6bafa-5743-425e-8def-bd9219cd756c@suse.cz> <161638da-3b2b-7912-2ae2-3b2936ca1537@linux.vnet.ibm.com> <7f85724c-6fc1-bb51-11e4-15fc2f89372b@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7f85724c-6fc1-bb51-11e4-15fc2f89372b@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 24-05-17 12:10:13, Anshuman Khandual wrote: [...] > So the question is are we willing to do all these changes across > the tree to achieve common definitions of KB, MB, GB, TB in the > kernel ? Is it worth ? I do not think this is worth losing time. Any tree wide change should have a considerable advantage in the end. These macro helpers do not sound overly important to care. But that is just my 2c -- Michal Hocko SUSE Labs