From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764530AbdEXNkH (ORCPT ); Wed, 24 May 2017 09:40:07 -0400 Received: from www.llwyncelyn.cymru ([82.70.14.225]:58576 "EHLO fuzix.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752602AbdEXNkF (ORCPT ); Wed, 24 May 2017 09:40:05 -0400 Date: Wed, 24 May 2017 14:39:32 +0100 From: Alan Cox To: Matthias Kaehlcke Cc: Zha Qipeng , Darren Hart , Andy Shevchenko , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Douglas Anderson Subject: Re: [PATCH] platform/x86: intel_pmc_ipc: Delete unused function ipc_data_readb() Message-ID: <20170524143932.11593845@alans-desktop> In-Reply-To: <20170523205539.71450-1-mka@chromium.org> References: <20170523205539.71450-1-mka@chromium.org> Organization: Intel Corporation X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 May 2017 13:55:39 -0700 Matthias Kaehlcke wrote: > The function was added by commit 0a8b83530b6f ("intel_pmc_ipc: Add Intel > Apollo Lake PMC IPC driver") in 2015 and hasn't been used since then. > Removing it fixes the following warning when building with clang: > > drivers/platform/x86/intel_pmc_ipc.c:189:18: error: unused function > 'ipc_data_readb' [-Werror,-Wunused-function] It is however also part of the API and a consistent sensible function to have present should it be needed. As it's static it's eliminated correctly by gcc. I'm all for eliminating unused functions but in this case I have to wonder Alan