From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S940566AbdEXPgR (ORCPT <rfc822;w@1wt.eu>);
        Wed, 24 May 2017 11:36:17 -0400
Received: from mail-pf0-f194.google.com ([209.85.192.194]:34282 "EHLO
        mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1760072AbdEXPgP (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 24 May 2017 11:36:15 -0400
Date: Thu, 25 May 2017 00:35:56 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: David Carrillo-Cisneros <davidcc@google.com>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>, Simon Que <sque@chromium.org>,
        Wang Nan <wangnan0@huawei.com>, Jiri Olsa <jolsa@kernel.org>,
        He Kuang <hekuang@huawei.com>, Masami Hiramatsu <mhiramat@kernel.org>,
        David Ahern <dsa@cumulusnetworks.com>,
        Stephane Eranian <eranian@google.com>, Paul Turner <pjt@google.com>,
        kernel-team@lge.com
Subject: Re: [PATCH v2 01/13] perf header: encapsulate read and swap
Message-ID: <20170524153556.GB27760@danjae.aot.lge.com>
References: <20170523074853.54892-1-davidcc@google.com>
 <20170523074853.54892-2-davidcc@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20170523074853.54892-2-davidcc@google.com>
User-Agent: Mutt/1.8.2 (2017-04-18)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 23, 2017 at 12:48:41AM -0700, David Carrillo-Cisneros wrote:
> Most callers of readn in perf header read either a 32 or a 64 bits
> number, error check it and swap it, if necessary.
> 
> Create do_read_u32 and do_read_u64 to simplify this usage.
> 
> Signed-off-by: David Carrillo-Cisneros <davidcc@google.com>
> ---
>  tools/perf/util/header.c | 212 +++++++++++++++++------------------------------
>  1 file changed, 76 insertions(+), 136 deletions(-)
> 
> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index 948b2c5efb65..1dd4dbe13f88 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
> @@ -117,27 +117,56 @@ static int do_write_string(int fd, const char *str)
>  	return write_padded(fd, str, olen, len);
>  }
>  
> +static int __do_read(int fd, void *addr, ssize_t size)
> +{
> +	ssize_t ret = readn(fd, addr, size);
> +
> +	if (ret != (ssize_t)size)

The 'size' is already ssize_t.

Thanks,
Namhyung


> +		return ret < 0 ? (int)ret : -1;
> +	return 0;
> +}