From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1036126AbdEXVxQ (ORCPT ); Wed, 24 May 2017 17:53:16 -0400 Received: from mga01.intel.com ([192.55.52.88]:58217 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033822AbdEXVxN (ORCPT ); Wed, 24 May 2017 17:53:13 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,388,1491289200"; d="scan'208";a="106247831" Date: Wed, 24 May 2017 14:52:59 -0700 From: Jarkko Sakkinen To: tpmdd-devel@lists.sourceforge.net, jmorris@namei.org Cc: linux-security-module@vger.kernel.org, Peter Huewe , Marcel Selhorst , Jason Gunthorpe , open list Subject: Re: [PATCH] tpm, tpm_infineon: remove useless snprintf() calls Message-ID: <20170524215259.xkaqrnhcb44jpyd5@intel.com> References: <20170524212916.9106-1-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170524212916.9106-1-jarkko.sakkinen@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2017 at 02:29:16PM -0700, Jarkko Sakkinen wrote: > The memory copy from rodata to stack is useless. > > Signed-off-by: Jarkko Sakkinen I already applied this, reviewed-by would be nice for this one but given how obvious this change is, it is not mandatory. I take my chances on this one as a maitainer. /Jarkko > --- > drivers/char/tpm/tpm_infineon.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/char/tpm/tpm_infineon.c b/drivers/char/tpm/tpm_infineon.c > index e3cf9f3545c5..3b1b9f9322d5 100644 > --- a/drivers/char/tpm/tpm_infineon.c > +++ b/drivers/char/tpm/tpm_infineon.c > @@ -397,7 +397,7 @@ static int tpm_inf_pnp_probe(struct pnp_dev *dev, > int vendorid[2]; > int version[2]; > int productid[2]; > - char chipname[20]; > + const char *chipname; > struct tpm_chip *chip; > > /* read IO-ports through PnP */ > @@ -488,13 +488,13 @@ static int tpm_inf_pnp_probe(struct pnp_dev *dev, > > switch ((productid[0] << 8) | productid[1]) { > case 6: > - snprintf(chipname, sizeof(chipname), " (SLD 9630 TT 1.1)"); > + chipname = " (SLD 9630 TT 1.1)"; > break; > case 11: > - snprintf(chipname, sizeof(chipname), " (SLB 9635 TT 1.2)"); > + chipname = " (SLB 9635 TT 1.2)"; > break; > default: > - snprintf(chipname, sizeof(chipname), " (unknown chip)"); > + chipname = " (unknown chip)"; > break; > } > > -- > 2.11.0 >