From: David Miller <davem@davemloft.net>
To: clabbe.montjoie@gmail.com
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/5] net-next: stmmac: rework the speed selection
Date: Thu, 25 May 2017 13:08:53 -0400 (EDT) [thread overview]
Message-ID: <20170525.130853.606472240884291471.davem@davemloft.net> (raw)
In-Reply-To: <20170524071647.7921-1-clabbe.montjoie@gmail.com>
From: Corentin Labbe <clabbe.montjoie@gmail.com>
Date: Wed, 24 May 2017 09:16:42 +0200
> The current stmmac_adjust_link() part which handle speed have
> some if (has_platform) code and my dwmac-sun8i will add more of them.
>
> So we need to handle better speed selection.
> Moreover the struct link member speed and port are hard to guess their
> purpose. And their unique usage are to be combined for writing speed.
>
> My first try was to create an adjust_link() in stmmac_ops but it duplicate some code
>
> The current solution is to have direct value for 10/100/1000 and a mask for them.
>
> The first 4 patchs fix some minor problem found in stmmac_adjust_link() and reported by Florian Fainelli in my previous serie.
> The last patch is the real work.
>
> This series is tested on cubieboard2 (dwmac1000) and opipc (dwmac-sun8i).
Series applied.
prev parent reply other threads:[~2017-05-25 17:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 7:16 Corentin Labbe
2017-05-24 7:16 ` [PATCH v3 1/5] net-next: stmmac: Convert new_state to bool Corentin Labbe
2017-05-24 7:16 ` [PATCH v3 2/5] net-next: stmmac: Remove unnecessary parenthesis Corentin Labbe
2017-05-24 7:16 ` [PATCH v3 3/5] net-next: stmmac: use SPEED_xxx instead of raw value Corentin Labbe
2017-05-24 7:16 ` [PATCH v3 4/5] net-next: stmmac: Convert old_link to bool Corentin Labbe
2017-05-24 7:16 ` [PATCH v3 5/5] net-next: stmmac: rework the speed selection Corentin Labbe
2017-05-25 17:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525.130853.606472240884291471.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=clabbe.montjoie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®