From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S970210AbdEYUdg (ORCPT ); Thu, 25 May 2017 16:33:36 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:33310 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965630AbdEYUdd (ORCPT ); Thu, 25 May 2017 16:33:33 -0400 Date: Thu, 25 May 2017 16:33:29 -0400 (EDT) Message-Id: <20170525.163329.1506857538759050908.davem@davemloft.net> To: petedaws@gmail.com Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, stephen@networkplumber.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets From: David Miller In-Reply-To: <20170526060842.4bd21054@udesktop> References: <20170526054627.00dcdeeb@udesktop> <20170525.154914.1347048861561693629.davem@davemloft.net> <20170526060842.4bd21054@udesktop> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 25 May 2017 12:51:58 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Dawson Date: Fri, 26 May 2017 06:08:42 +1000 > On Thu, 25 May 2017 15:49:14 -0400 (EDT) > David Miller wrote: > >> Still not correct, you need to use a "Fixes: " tag of the form: >> >> Fixes: 90427ef5d2a4 ("ipv6: fix flow labels when the traffic class is non-0") >> >> And it must appear of the first line of tags, before signoffs and acks, >> with no empty lines in between. > > Here is my proposed commit message in full. Note that > the "Fixes" line extends to 78 chars. Is this OK? Yes, that looks perfect.