From: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
To: acme@kernel.org
Cc: anton@samba.org, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, treeze.taeung@gmail.com,
borntraeger@de.ibm.com, linux-kernel@vger.kernel.org,
kim.phillips@arm.com,
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Subject: [PATCH] perf/annotate/powerpc: Fix branch instruction with multiple operands
Date: Thu, 25 May 2017 11:29:57 +0530 [thread overview]
Message-ID: <20170525055957.7779-1-ravi.bangoria@linux.vnet.ibm.com> (raw)
Perf annotate is dropping the cr* fields from branch instructions.
Fix it by adding support to display branch instructions having
multiple operands.
Objdump of int_sqrt:
20.36 | c0000000004d2694: subf r10,r10,r3
| c0000000004d2698: v bgt cr6,c0000000004d26a0 <int_sqrt+0x40>
1.82 | c0000000004d269c: mr r3,r10
29.18 | c0000000004d26a0: mr r10,r8
| c0000000004d26a4: v bgt cr7,c0000000004d26ac <int_sqrt+0x4c>
| c0000000004d26a8: mr r10,r7
Before Patch:
20.36 | subf r10,r10,r3
| v bgt 40
1.82 | mr r3,r10
29.18 | 40: mr r10,r8
| v bgt 4c
| mr r10,r7
After patch:
20.36 | subf r10,r10,r3
| v bgt cr6,40
1.82 | mr r3,r10
29.18 | 40: mr r10,r8
| v bgt cr7,4c
| mr r10,r7
Reported-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
---
tools/perf/util/annotate.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 683f834..a031c4d 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -257,10 +257,18 @@ static int jump__parse(struct arch *arch __maybe_unused, struct ins_operands *op
static int jump__scnprintf(struct ins *ins, char *bf, size_t size,
struct ins_operands *ops)
{
+ const char *c = strchr(ops->raw, ',');
+
if (!ops->target.addr || ops->target.offset < 0)
return ins__raw_scnprintf(ins, bf, size, ops);
- return scnprintf(bf, size, "%-6.6s %" PRIx64, ins->name, ops->target.offset);
+ if (c++ != NULL)
+ return scnprintf(bf, size, "%-6.6s %.*s%" PRIx64,
+ ins->name, c - ops->raw, ops->raw,
+ ops->target.offset);
+ else
+ return scnprintf(bf, size, "%-6.6s %" PRIx64,
+ ins->name, ops->target.offset);
}
static struct ins_ops jump_ops = {
--
1.8.3.1
next reply other threads:[~2017-05-25 6:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 5:59 Ravi Bangoria [this message]
2017-05-26 23:23 ` [PATCH] perf/annotate: " Kim Phillips
2017-06-01 13:09 ` Arnaldo Carvalho de Melo
2017-06-01 13:47 ` Ravi Bangoria
2017-06-01 14:29 ` [PATCH v2] " Kim Phillips
2017-06-01 15:03 ` Ravi Bangoria
2017-06-01 16:42 ` Arnaldo Carvalho de Melo
2017-06-01 17:50 ` Arnaldo Carvalho de Melo
2017-06-07 15:57 ` [tip:perf/urgent] perf annotate: " tip-bot for Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525055957.7779-1-ravi.bangoria@linux.vnet.ibm.com \
--to=ravi.bangoria@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=anton@samba.org \
--cc=borntraeger@de.ibm.com \
--cc=kim.phillips@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=treeze.taeung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®