From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938178AbdEYMCj (ORCPT ); Thu, 25 May 2017 08:02:39 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35389 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbdEYMCe (ORCPT ); Thu, 25 May 2017 08:02:34 -0400 Date: Thu, 25 May 2017 21:02:36 +0900 From: Sergey Senozhatsky To: Petr Mladek Cc: Sergey Senozhatsky , Nicolas Iooss , Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] printk: add __printf attributes to internal functions Message-ID: <20170525120236.GD386@jagdpanzerIV.localdomain> References: <20170522152211.GF12489@pathway.suse.cz> <20170524054950.6722-1-nicolas.iooss_linux@m4x.org> <20170525112902.GG12489@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170525112902.GG12489@pathway.suse.cz> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (05/25/17 13:29), Petr Mladek wrote: > On Wed 2017-05-24 07:49:50, Nicolas Iooss wrote: > > When compiling with -Wsuggest-attribute=format, gcc complains that some > > functions in kernel/printk/printk_safe.c transmit their argument to > > printf-like functions without having a printf attribute. Silence these > > warnings by adding relevant __printf attributes. > > > > Signed-off-by: Nicolas Iooss > > Acked-by: Petr Mladek > > --- > > v2: add __printf attribute to the definition of vprintk_nmi() which is > > used when CONFIG_PRINTK_NMI is not defined. > > Sergey, I believe that that your Reviewed-by is still valid even after > this small update. Is that true, please? sure. sorry about that! Reviewed-by: Sergey Senozhatsky -ss