From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969649AbdEYN4n (ORCPT ); Thu, 25 May 2017 09:56:43 -0400 Received: from mail-bn3nam01on0047.outbound.protection.outlook.com ([104.47.33.47]:62112 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S968988AbdEYN4j (ORCPT ); Thu, 25 May 2017 09:56:39 -0400 Authentication-Results: canonical.com; dkim=none (message not signed) header.d=none;canonical.com; dmarc=none action=none header.from=quantenna.com; Date: Thu, 25 May 2017 16:56:24 +0300 From: Sergey Matyukevich To: Colin King Cc: Avinash Patil , Sergey Matyukevich , Igor Mitsyanko , Kalle Valo , Huizhao Wang , Kamlesh Rath , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][net-next] qtnfmac: remove duplicated assignment to mac Message-ID: <20170525135624.z723srd7evhml5e3@bars> Mail-Followup-To: Colin King , Avinash Patil , Igor Mitsyanko , Kalle Valo , Huizhao Wang , Kamlesh Rath , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170525134503.12106-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170525134503.12106-1-colin.king@canonical.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Originating-IP: [195.182.157.76] X-ClientProxiedBy: VI1P194CA0008.EURP194.PROD.OUTLOOK.COM (10.175.178.18) To BLUPR05MB1921.namprd05.prod.outlook.com (10.162.224.11) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLUPR05MB1921: X-MS-Office365-Filtering-Correlation-Id: 7c437d4d-78c6-41ae-f630-08d4a375dbf4 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:BLUPR05MB1921; X-Microsoft-Exchange-Diagnostics: 1;BLUPR05MB1921;3:gkhcySObFY0DDr/AfxHvJj2oqicZYC03wy0C/QTGhsNa24DOTFle8xQYXm+0V0VCSuahG2XGCl54A+N9fwy43cMnakqSmlCefZQrfE5hoKFfJFO0h/sX19q8q3F6DWIHHqeYy0YXkdcH9qGw446paWqcs+TTPeX7lM5qx0SUDLgdlB0WTjQJgqf+PNfGQMcqj0eXJgW514LmmFX6d1KMOQaoEn0Vz7SFf9MxAKQRkDrYb5spnKd1jEC8Nz3ZwIFiT7x/jqi8GRPTvuuK90NqCxLJIRYK+6CQ96w+ItYmJFI2Qq6Ow7XEKz/4/fx3xwhkjYBkf5KuOfnCNxtqSkrKbA==;25:h+7TEMnXNsrtDhEMlxj0ot0fb0ZKdfDGhIK5fTztOZNBlNhtEn6kD8Ym2e1uoMMhNDK3SgjSSbRiljziEMG45KBP5ukpeucMMLlNxdz84HKiKHNt+D1Rj08voQAxgTioOJW3t0VEF75vgsVUXkbBzw24vz5o9v3V5rxzXlITup9bW43gMRKdW1515HMsa1jyy8TDr4wNok7zqWt6qroNh+4ROopD8eh0EHkNVybRzsUnzYevxHIbmZb2U9s/du3CemkOp/cNV9XehtacnY3bzOicEbMRP5B4x5u0cwPkusMxx/nOehLkMJnN1MLVKJHbltFMSiCXoPkY19Gls6BPRCnrlF//ZYbiQj6g7sdWtSWOMqDjGd9XFmxlMlxGCKblYrP+tIOvQTk4uZI+Ziq49Z7psDF/pTn7EWA+xOtTIui5GXV1vC3Hum7x8hYy0GM6Bt+ftqvuEkd7FR4M0MPq9FKpq5eUHPZgNjXeCt0avYw= X-Microsoft-Exchange-Diagnostics: 1;BLUPR05MB1921;31:lJ23dyuAfT0IxYmG3Ok4zdwu+PsSokg5fBf9BavCj378eccOLe+ty6E7yCuuAAlS2wkNvDLkTQAY/V7+KnwreacDwNypQ1XFay2eLOK63wcJUf2aY7uUmW2uWqkfxlrYSIzul4hB3NsekeCiP/cY0siRhcSKq96ewqP/+AKfuMCOcy+m6eCDhChg6EAwmKR1CD+wZzseDRQa4/PbMfpmRS+fsrmtTZnoxrDv9QZRs5s=;20:O24b4nC2mUVbbO0ienfmJrkCDzPQW8hdcIGytb2hx8sxQR/RKHhP4jW7RlBCmuF4EZIbfsV77wNruwHnYIsQ+i73tPrq7Q6VteNicJuQZ9+PWBxICEsx6bKlxqKypCFz6SaSS70ZLHV8RhRRMSk8EXc7l8srSsUNAtANB6sO6LrBAfnIYldDt/V/uUnonZVuiVi9tpaAxv1qm48Ii31FOAZXZPAudqf0b41uKJekbozrmzKYXPVocjvWmlU9Z4WcY/rGZMets+Sy0+N5D2JGNXf9wV+DzF95vZz8oZSL/55b1bu/QTzx/v8MCsn22m136Y91Gz/tWWng8H6yfa587xZe61LNE5KR+Vau+IaeECgjcR2Xt2vYvYir+D+YlZ1GBxwWFSxba/MwCOQZ8wB0I4HW0eBksWLvSxe0aRkVCDM+1vCzjSEK+5Siqolo0Vr0jlo5TnBVMOxySrj4lGRkJILc3UzzE9yrP+i8lBZNIH3eALXobdjeGA3CimRSxQIX X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(198206253151910); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(6072148);SRVR:BLUPR05MB1921;BCL:0;PCL:0;RULEID:;SRVR:BLUPR05MB1921; X-Microsoft-Exchange-Diagnostics: 1;BLUPR05MB1921;4:pTvD//uOxCrvX/iIoYiVl/KeWePgNs/P+L2/9e3KTRmcGWdib8yiGIsy10U17jfF2uJYZRwIkpAVszoUBAlTNz04HAZ/y0MFZ3VjqYaV4ZmKI6rwh7VlluM7L3aI+lRiu4c3MIk+S0BQVM4bDlmWOeJJcp6JLpacPChUrOBpI4KEhbZ7J7TZ/gOgz81OspRyxic80KXzLzWuuog5AlSvK7szhNWv0GWIWh4y02me9v+FoevYv9z6sqcEODkqchRoSfAjnXZ395SMYcLe+UEzCgvAfODddjkQ+x/lEgkQKeWPmf5G3EZN4yOwJh+fxe/2Jh6qy0AIe/vgyXXgdUTGjB3CPRnJpnkUTmWsIJAXBIF8MBSuE0SUayS8VdyRuQeTdNdVIcEITo+uderTUk95o3+DCugBL+Klk1lKPfDYqQyzQNFyPKFQT/DnKn8w+3eFAy5y79x7WxL7OTMEAWpCzPfJwb1HHRtoFp2xoYl/3zP6ehcs1Jr6GSqUyq1rvSXoHb+Th29rdybjZnFFjgLF55YCncHoEROVDfXaH2h4aCWS0urdUpzKH9vagv8MPzXEedS9PcOVLpNgkls5cTkUujdzJptckc4NCEGlT9dbvIQmVSm4jNllEUsvmMlgAI6b9zFc+axJ5MveIfbrCa3twyFKrSU03a3rP6wDro36sCK0JIdA5D13cpbJi2nmWAyHjnVsh42tYAEQNr4bNEz7kP0a1gz+jymITGrGAfy4e8IdBCHA3/YhTv83P39JJ4tEykeT20EiJRqC00iSwZaVfzmlqJhfdeiqpG4vV0W+qgOFyXk2K200U44YyUjU18b0pOj0bLCNn5J2DLFZb7Ct2Q== X-Forefront-PRVS: 0318501FAE X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39830400002)(39450400003)(39400400002)(39410400002)(575784001)(86362001)(229853002)(50986999)(6916009)(2950100002)(76176999)(54356999)(189998001)(50466002)(66066001)(38730400002)(110136004)(6666003)(305945005)(2906002)(7736002)(42186005)(6496005)(478600001)(6246003)(5660300001)(33646002)(33716001)(81166006)(8676002)(6116002)(23726003)(3846002)(1076002)(4326008)(83506001)(47776003)(53936002)(55016002)(9686003)(25786009);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR05MB1921;H:bars;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR05MB1921;23:+0IU3FlPq464K81YAs07jpu0tegA9UHRwib03KEjq?= =?us-ascii?Q?DgIB0AbQ2hK7jUun01IVg8lvO4klsiTqVMFJPtNfsrkZEVWfXHpkBC3Z4a4w?= =?us-ascii?Q?4KD4Wr6w2Qys3BgnvByYUoi3tl8LolqcYO5ZSSZs6gG8+BUlYzlG7iYiJV/Z?= =?us-ascii?Q?ZkoAFLztQiNIPGw4Zb9jEWHqwcLsHFDPzyOWWJshlx78IizdE3KnZVp5S/vA?= =?us-ascii?Q?kJpAw0hxv695yNdulPNK6c7niaRi7bpug1FeflyIBMGYwnzsj2eDfdqtIT8L?= =?us-ascii?Q?EZTAWbnkOGLZtHoE6tCsTKxfgn/RlFSRHVUigHOIHGqCm0Xap6q89TBLBfE6?= =?us-ascii?Q?PaXdW/UkF8h1jVWuL6zHnqcz/phZ0Ld4euYaw9UGV5/BWTq5QaO3jeUr4grs?= =?us-ascii?Q?jdYQdrPnIXPEspyaQZQ/KDfTY7syCWcyPZr02o3hfuS2XAAjc8dTvtYOX13Y?= =?us-ascii?Q?F9iMk7m8TQDZ+fCLAlg1CXoE5CKtIMsdupRJooqmWasyAl/vG8GGv6lmm85G?= =?us-ascii?Q?NRYwZQcxFyl/bwO5SSCGrCzAZcA/ui3QVeih03A9QYA/DzATeHf+4zYNn+5w?= =?us-ascii?Q?mUruB892QUnnDvTnifzRT7HlSNu8CR0QFipgNpYoDplWeG+6ybIJ2sjaO0w8?= =?us-ascii?Q?YzQ/RMEjnjCJNHWNSnVvcXWt6nLqzuxpXL9F5RRyocUxVgVR89/4j0SFcAHY?= =?us-ascii?Q?SPM8FN2njCkBrHNGLflrgU5dKHPdSzJjQSJbqOt7EBbQbCY1dXLvCK0fwNqJ?= =?us-ascii?Q?G/7IygiPYIJsMNUyMogimjeBC5lX31YEsmGVLR2ud5hP1MNnoI4A3lCyCR6y?= =?us-ascii?Q?cpscoV9Z4ak71JwUyaqckIbSZUuoGFVNinuAipEaTPD9sfJxqI3iZ6DLjOpJ?= =?us-ascii?Q?hedXLARlwJE9pykX6gcxKAjW41fdmD5RwK30vPQz9hJtGulnTq8cmojB/xVd?= =?us-ascii?Q?NU5XyY4WTJlRuxsoMdxsVSu+SP6eT9tXD+U2ugW/Tuhbu591StOvhm4lo99F?= =?us-ascii?Q?g8W3Zjwg5SmGh0Sj+dY3JU4WxoDuCwLK5o/3StWo5WFMJLqJuRyTn4jI6rNS?= =?us-ascii?Q?wK70ti/2HDdvdD6+ULI1cgc3OrN?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR05MB1921;6:5giWZ9353wLJSnhDjittNy8HQbhZ3b4tBF8Z2DfFA0yVEUOLyndIAJqP0cvX36sk3cR5Q09ZIDxXpL5PPx08KxZOZjv0XydqctJdXqrJxDEdn5ebVkJcMHsM82wQ9Ek/e7dgSYOE4R5SS5+0FS3kBDUdIxlrt8/6rYdvXzhX14urufNJSUlhciiAiM0MQLFvuYDwwuTf9KFxIoQk4QK3ncIJO2BUJKxLweumkYPgjCoFZpmLfXZveT+AYAxFR4e6ktX04lmEUYlv3qSFJ6pBlSmu68+XzWuoh+a7Kql9JTg8EsWOg8exikkbBZqVe6wIR+3hJVu35OFrk9k0x1e3Fk2OE8dAq62PwhVVQraFkzSJzRvpsEqtUeiazIHWVDRMflWUmJhlbAw16PDwSfWmNnkIcnY/WmbboAL7TKLm8JMqAQYDDl9QFJtVPdv6hUlRW0YPmEG9mMU9R2ITsZr5mkYGsH3LcIlEHU3OCWLIcqYk1Ka0ylgheR/APfNY7zLrXKUxp7YuYpnwlYHPL7QbWA==;5:tIdaeCdrNBF8So2Yy+DHmPZZ8gq1vpoYvww1ToWGX6nChCZYoqFwhJumI1fYQ92D/TxHHreq7CK81ql9vSuT9KPHVgze/p1JnUB0XTGbe3hLrP1hLSxGR7huDsxGi/L7PDuJaVMn/U8bHrrAL0ZkPg==;24:Zeobtp4nW2UCY4y7eJjTztWrWhq2+O97FLKM3GuNvPOfy3NMSmS6SCBV65PmNi2Jr3+r+EwdFr9n9MvTSAZH7/DWbei7/bQf2AX6XxfGFdg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BLUPR05MB1921;7:nczynXDgm5LR91AcP10/MHCX9Ar8xRRw/X5berhM912QyjfBRk79QB5NbBREQmX+Tcg5NZ00CfISnUmE0/wXRu5Vs7RAzzKZX6Ful0+G/hBBv6PffXtOxI9z4sAP1BtKoPojwa9KpwMfn08+0pCAx21v4HEvd0lLUouwZGPjDxvkOdTA6U1N/iAVVTt+i/1bkvvfAdC+Hcw2L6PtkOavcGoJ8nh5aXWf8QrHBNPQdXQGJul7srbIkCq8G8kDAgGDSqSfKJMIevpOfoeuwok899uH5ZNvXwvb8tBJsZHn1SMuyUSdw5akbfwCmdDnzXPXq08+DCGhgdQw1CX1Y5TLiA== X-OriginatorOrg: quantenna.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2017 13:56:34.3472 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR05MB1921 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > mac is being assigned twice, remove redundant 2nd assignment. > > Detected by CoverityScan, CID#1437554 ("Incorrect expression") > > Signed-off-by: Colin Ian King > --- > drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c > index fc0ce2c09097..e3c090008125 100644 > --- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c > +++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c > @@ -922,7 +922,7 @@ void qtnf_netdev_updown(struct net_device *ndev, bool up) > void qtnf_virtual_intf_cleanup(struct net_device *ndev) > { > struct qtnf_vif *vif = qtnf_netdev_get_priv(ndev); > - struct qtnf_wmac *mac = mac = wiphy_priv(vif->wdev.wiphy); > + struct qtnf_wmac *mac = wiphy_priv(vif->wdev.wiphy); Thanks ! Acked-by: Sergey Matyukevich