From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969893AbdEYQfh (ORCPT ); Thu, 25 May 2017 12:35:37 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:32946 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967144AbdEYQfd (ORCPT ); Thu, 25 May 2017 12:35:33 -0400 Date: Thu, 25 May 2017 09:35:25 -0700 From: Dmitry Torokhov To: Greg Kroah-Hartman Cc: Wei-Ning Huang , Julius Werner , Guenter Roeck , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/8] firmware: vpd: do not leave freed section attributes to the list Message-ID: <20170525163525.GB26128@dtor-ws> References: <20170524000748.39310-1-dmitry.torokhov@gmail.com> <20170525134058.GA11968@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170525134058.GA11968@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 25, 2017 at 03:40:58PM +0200, Greg Kroah-Hartman wrote: > On Tue, May 23, 2017 at 05:07:41PM -0700, Dmitry Torokhov wrote: > > We should only add section attribute to the list of section attributes > > if we successfully created corresponding sysfs attribute. > > > > Fixes: 049a59db34eb ("firmware: Google VPD sysfs driver") > > Signed-off-by: Dmitry Torokhov > > Reviewed-by: Guenter Roeck > > --- > > drivers/firmware/google/vpd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Next time, can you split this up into 2 series, one for the current > kernel, and the rest for the "next" release? I've tried to split them > up myself here, hopefully it works... OK, I will. It is just I did not consider either of issues serious enough so they could not wait for next release: failure to allocate tiny amounts of memory is impossible to trigger with current kernels. Same goes for the other patches. For example, one needs to not only manage to get sysfs attribute creation to fail, but also then unload the driver, to trigger the issue. Unlikely to happen in real life. Thanks. -- Dmitry