From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942634AbdEYQoU (ORCPT ); Thu, 25 May 2017 12:44:20 -0400 Received: from mga07.intel.com ([134.134.136.100]:12424 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758705AbdEYQoT (ORCPT ); Thu, 25 May 2017 12:44:19 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,392,1491289200"; d="scan'208";a="1152777699" Date: Thu, 25 May 2017 09:44:16 -0700 From: Jarkko Sakkinen To: Peter Huewe Cc: tpmdd-devel@lists.sourceforge.net, jmorris@namei.org, linux-security-module@vger.kernel.org, Marcel Selhorst , Jason Gunthorpe , open list Subject: Re: Re: [PATCH] tpm, tpm_infineon: remove useless snprintf() calls Message-ID: <20170525164416.5dn7l3eu4tkudypn@intel.com> References: <20170524212916.9106-1-jarkko.sakkinen@linux.intel.com> <20170524215259.xkaqrnhcb44jpyd5@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 25, 2017 at 07:29:05AM +0200, Peter Huewe wrote: > > The memory copy from rodata to stack is useless. > > > > Signed-off-by: Jarkko Sakkinen > > After review, yes that should work. > Reviewed-by: Peter Huewe Yes, the string gets stored to rodata section where it is copied to stack :-) Thanx! /Jarkko