From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162730AbdEYWlI (ORCPT ); Thu, 25 May 2017 18:41:08 -0400 Received: from mga04.intel.com ([192.55.52.120]:2922 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758983AbdEYWkM (ORCPT ); Thu, 25 May 2017 18:40:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,393,1491289200"; d="scan'208";a="1152905044" Date: Thu, 25 May 2017 15:40:11 -0700 From: Jarkko Sakkinen To: Josh Zimmerman Cc: linux-kernel@vger.kernel.org, Jason Gunthorpe , tpmdd-devel@lists.sourceforge.net, Greg KH , jmorris@namei.org Subject: Re: [PATCH v3] Add "shutdown" to "struct class". Message-ID: <20170525224011.whm56yzautdo74cj@intel.com> References: <20170515173438.13420-1-joshz@google.com> <20170525130930.GA16244@kroah.com> <20170525160925.GA25318@kroah.com> <20170525164118.GA28995@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170525164118.GA28995@kroah.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Josh, On Thu, May 25, 2017 at 06:41:18PM +0200, Greg Kroah-Hartman wrote: > On Thu, May 25, 2017 at 09:24:30AM -0700, Josh Zimmerman wrote: > > On Thu, May 25, 2017 at 9:09 AM, Greg Kroah-Hartman > > wrote: > > > On Thu, May 25, 2017 at 08:40:28AM -0700, Josh Zimmerman wrote: > > >> Thanks, Greg. > > >> > > >> Greg, Jarkko: Do either of you you have any objections to me > > >> backporting these changes to 4.4 and 4.9? I'd like to make sure that > > >> at least the couple most recent LTS kernels have this patch. > > > > > > Why? What bug does this solve? > > If a TPM2 device has power removed without a TPM2_Shutdown being > > issued, it will increment its "dictionary attack" counter. After that > > counter reaches a certain value, the TPM2 device will lock the user > > out. Adding the shutdown callback allows the TPM kernel driver to send > > TPM2_Shutdown to all TPM2 devices. > > Is all of that in the tpm patch description? If so, great, if not, > please add it. > > > > If it meets the rules of > > > Documentation/stable_kernel_rules.txt (or whereever that file moved to), > > > that's fine with me. > > Documentation/process/stable-kernel-rules.rst, right? To comply with > > option 1 referred to there (Adding the appropriate "Cc:" to the > > description), should I send a new patch email or just reply to this > > one and quote the relevant part? (I don't believe the document > > specifies.) > > You (or who ever applies these patches) needs to add the cc: stable tag > to them. I suggest resend these, as a patch series, with that in it, so > that it all makes more sense and the tpm maintainer has an easy job of > it. > > thanks, > > greg k-h Can you send one more patch set with these two patches and Cc-tags and refined descriptions where needed. If you do this, I will apply them to my tree and send PR to James Morris. Thank you. /Jarkko