From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939925AbdEZIaN (ORCPT ); Fri, 26 May 2017 04:30:13 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:57175 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1037022AbdEZI3U (ORCPT ); Fri, 26 May 2017 04:29:20 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Date: Fri, 26 May 2017 09:28:59 +0100 From: Chris Wilson To: Xiaoguang Chen , alex.williamson@redhat.com, kraxel@redhat.com, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, zhenyuw@linux.intel.com, zhiyuan.lv@intel.com, intel-gvt-dev@lists.freedesktop.org, zhi.a.wang@intel.com, kevin.tian@intel.com Subject: Re: [Intel-gfx] [PATCH v5 4/5] drm/i915/gvt: Dmabuf support for GVT-g Message-ID: <20170526082859.GS10827@nuc-i3427.alporthouse.com> Mail-Followup-To: Chris Wilson , Xiaoguang Chen , alex.williamson@redhat.com, kraxel@redhat.com, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, zhenyuw@linux.intel.com, zhiyuan.lv@intel.com, intel-gvt-dev@lists.freedesktop.org, zhi.a.wang@intel.com, kevin.tian@intel.com References: <1495535521-2120-1-git-send-email-xiaoguang.chen@intel.com> <1495535521-2120-5-git-send-email-xiaoguang.chen@intel.com> <20170525132825.GO10827@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170525132825.GO10827@nuc-i3427.alporthouse.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 25, 2017 at 02:28:25PM +0100, Chris Wilson wrote: > On Tue, May 23, 2017 at 06:32:00PM +0800, Xiaoguang Chen wrote: > > + gtt_entries = (gen8_pte_t __iomem *)dev_priv->ggtt.gsm + > > + (fb_gma >> PAGE_SHIFT); > > + for_each_sg(st->sgl, sg, fb_size, i) { > > + sg->offset = 0; > > + sg->length = PAGE_SIZE; > > + sg_dma_address(sg) = > > + GEN8_DECODE_PTE(readq(>t_entries[i])); > > + sg_dma_len(sg) = PAGE_SIZE; > > This assumes that the entries are PAGE_SIZE. This will not remain true. Ok, we will only be supporting different page sizes for ppgtt. However, it is probably better to use I915_GTT_PAGE_SIZE to match our insertions. -Chris -- Chris Wilson, Intel Open Source Technology Centre