From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1946533AbdEZBex (ORCPT <rfc822;w@1wt.eu>);
        Thu, 25 May 2017 21:34:53 -0400
Received: from mail.kernel.org ([198.145.29.99]:38338 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1758462AbdEZBew (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 25 May 2017 21:34:52 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 971AE239EF
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org
Date: Fri, 26 May 2017 10:34:48 +0900
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        Kees Cook <keescook@chromium.org>, LKML <linux-kernel@vger.kernel.org>,
        x86@kernel.org, "Luis R. Rodriguez" <mcgrof@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] x86/ftrace: Make sure that ftrace trampolines are not
 RWX
Message-Id: <20170526103448.6d6c70b56faece87efda7c9f@kernel.org>
In-Reply-To: <20170525111802.53105528@vmware.local.home>
References: <alpine.DEB.2.20.1705241459480.2201@nanos>
        <20170524134728.61a896c9@vmware.local.home>
        <alpine.DEB.2.20.1705242112210.2283@nanos>
        <20170524182547.5c085dc7@vmware.local.home>
        <20170525180910.0a19b5de03a86ad764e8ed6b@kernel.org>
        <20170525193443.0a829e456d8c26102d18a435@kernel.org>
        <20170525111802.53105528@vmware.local.home>
X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 25 May 2017 11:18:02 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 25 May 2017 19:34:43 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
> 
> 
> > OK, I've ensured that following command hits same BUG.
> > 
> > grep t /proc/kallsyms  | cut -f3 -d" " | grep -v .*\\..* | \
> > head -n 256 | while read i; do echo p $i+5 ; done >
> > tracing/kprobe_events
> > 
> > echo 1 > tracing/events/kprobes/enable 
> > echo 0 > tracing/events/kprobes/enable
> > echo > tracing/kprobe_events
> > sleep 5
> 
> Hi Masami,
> 
> Can you add a selftest that checks this too?

Yes, however, it should be included after my fix is
accepted, or it can cause a kernel panic...

Thanks,



-- 
Masami Hiramatsu <mhiramat@kernel.org>