From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967346AbdEZPCu (ORCPT ); Fri, 26 May 2017 11:02:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:58850 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966959AbdEZPCf (ORCPT ); Fri, 26 May 2017 11:02:35 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD81323958 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Fri, 26 May 2017 11:02:32 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton Subject: Re: [for-next][PATCH 09/33] selftests: ftrace: Add test to test reading of set_ftrace_file Message-ID: <20170526110232.3ed3dae1@gandalf.local.home> In-Reply-To: <20170522122308.471fc20edada0455c30577da@kernel.org> References: <20170421213020.875637678@goodmis.org> <20170421213329.304791901@goodmis.org> <20170522122308.471fc20edada0455c30577da@kernel.org> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 May 2017 12:23:08 +0900 Masami Hiramatsu wrote: > Hi Steve, > > On Fri, 21 Apr 2017 17:30:29 -0400 > Steven Rostedt wrote: > > > From: "Steven Rostedt (VMware)" > > > > The set_ftrace_file lists both functions that are filtered, as well as > > function probes (triggers) that are attached to a function, like traceon or > > stacktrace, etc. The reading of this file is not as trivial as most pseudo > > files are, and there's been various bugs that have appeared in the past > > when there's a mix of probes and functions listed. There's also a difference > > when reading the file using dd with a block size of 1. > > Would you know which commit fixed this dd/cat differences on > set_ftrace_filter? When I've run this test on 4.9-stable kernel, > it failed because the result of "dd -bs=1" and "cat" on > set_ftrace_filter were different. > Probably one of the patches in this series before this one. -- Steve