From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1948444AbdEZRTg (ORCPT <rfc822;w@1wt.eu>);
        Fri, 26 May 2017 13:19:36 -0400
Received: from mx2.suse.de ([195.135.220.15]:33455 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S940893AbdEZRTG (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 26 May 2017 13:19:06 -0400
Date: Fri, 26 May 2017 18:19:03 +0100
From: Luis Henriques <lhenriques@suse.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Michal Hocko <mhocko@kernel.org>,
        Andy Lutomirski <luto@amacapital.net>,
        "Luis R. Rodriguez" <mcgrof@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 2/3] mm: kmemleak: Factor object reference updating
 out of scan_block()
Message-ID: <20170526171903.5q3e5vqbhzcymdcd@hermes.olymp>
References: <1495726937-23557-1-git-send-email-catalin.marinas@arm.com>
 <1495726937-23557-3-git-send-email-catalin.marinas@arm.com>
 <20170526160916.ptlc2huao3bn4qwq@hermes.olymp>
 <20170526162107.GC30853@e104818-lin.cambridge.arm.com>
 <20170526162329.GD30853@e104818-lin.cambridge.arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20170526162329.GD30853@e104818-lin.cambridge.arm.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 26, 2017 at 05:23:30PM +0100, Catalin Marinas wrote:
> On Fri, May 26, 2017 at 05:21:08PM +0100, Catalin Marinas wrote:
> > On Fri, May 26, 2017 at 05:09:17PM +0100, Luis Henriques wrote:
> > > On Thu, May 25, 2017 at 04:42:16PM +0100, Catalin Marinas wrote:
> > > > The scan_block() function updates the number of references (pointers) to
> > > > objects, adding them to the gray_list when object->min_count is reached.
> > > > The patch factors out this functionality into a separate update_refs()
> > > > function.
> > > > 
> > > > Cc: Michal Hocko <mhocko@kernel.org>
> > > > Cc: Andy Lutomirski <luto@amacapital.net>
> > > > Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>
> > > > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> [...]
> > > FWIW, I've tested this patchset and I don't see kmemleak triggering the
> > > false positives anymore.
> > 
> > Thanks for re-testing (I dropped your tested-by from the initial patch
> > since I made a small modification).
> 
> Sorry, the "re-testing" comment was meant at the other Luis on cc ;)
> (Luis R. Rodriguez). It's been a long day...

Heh, no worries!  What are the odds of having 2 different guys named Luis
testing the same patch? :-)

Cheers,
--
Luís