From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1949058AbdE0BRG (ORCPT ); Fri, 26 May 2017 21:17:06 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:35162 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1948739AbdEZVXM (ORCPT ); Fri, 26 May 2017 17:23:12 -0400 From: Matthias Kaehlcke To: Jens Axboe Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Douglas Anderson , Matthias Kaehlcke Subject: [PATCH 2/3] cfq-iosched: Fix warning about unused dummy functions Date: Fri, 26 May 2017 14:22:36 -0700 Message-Id: <20170526212237.103525-3-mka@chromium.org> X-Mailer: git-send-email 2.13.0.219.gdb65acc882-goog In-Reply-To: <20170526212237.103525-1-mka@chromium.org> References: <20170526212237.103525-1-mka@chromium.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Only define dummies for cfqg_stats_set_start_group_wait_time() and cfqg_stats_end_empty_time() when CONFIG_CFQ_GROUP_IOSCHED=y. This fixes the following warnings when building with clang: block/cfq-iosched.c:589:20: error: unused function 'cfqg_stats_set_start_group_wait_time' [-Werror,-Wunused-function] block/cfq-iosched.c:590:20: error: unused function 'cfqg_stats_end_empty_time' [-Werror,-Wunused-function] Signed-off-by: Matthias Kaehlcke --- block/cfq-iosched.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c index 36ab3645effc..b23c73db4cc0 100644 --- a/block/cfq-iosched.c +++ b/block/cfq-iosched.c @@ -588,8 +588,10 @@ static void cfqg_stats_update_avg_queue_size(struct cfq_group *cfqg) #else /* CONFIG_CFQ_GROUP_IOSCHED && CONFIG_DEBUG_BLK_CGROUP */ +#ifdef CONFIG_CFQ_GROUP_IOSCHED static inline void cfqg_stats_set_start_group_wait_time(struct cfq_group *cfqg, struct cfq_group *curr_cfqg) { } static inline void cfqg_stats_end_empty_time(struct cfqg_stats *stats) { } +#endif static inline void cfqg_stats_update_dequeue(struct cfq_group *cfqg) { } static inline void cfqg_stats_set_start_empty_time(struct cfq_group *cfqg) { } static inline void cfqg_stats_update_idle_time(struct cfq_group *cfqg) { } -- 2.13.0.219.gdb65acc882-goog