From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1037362AbdE0BRs (ORCPT ); Fri, 26 May 2017 21:17:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42112 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1948759AbdEZVx1 (ORCPT ); Fri, 26 May 2017 17:53:27 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 451D983F38 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jeyu@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 451D983F38 Date: Fri, 26 May 2017 14:53:25 -0700 From: Jessica Yu To: Miroslav Benes Cc: jpoimboe@redhat.com, jikos@kernel.org, mmarek@suse.com, pmladek@suse.com, jmoreira@suse.de, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] livepatch: Make livepatch dependent on !TRIM_UNUSED_KSYMS Message-ID: <20170526215325.fa4qeyhstijgmb7e@jeyu> References: <20170526124521.28592-1-mbenes@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20170526124521.28592-1-mbenes@suse.cz> X-OS: Linux jeyu 4.8.12-100.fc23.x86_64 x86_64 User-Agent: NeoMutt/20161126 (1.7.1) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 26 May 2017 21:53:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +++ Miroslav Benes [26/05/17 14:45 +0200]: >If TRIM_UNUSED_KSYMS is enabled, all unneeded exported symbols are made >unexported. Two-pass build of the kernel is done to find out which >symbols are needed based on a configuration. This effectively >complicates things for out-of-tree modules. > >Livepatch exports functions to (un)register and enable/disable a live >patch. The only in-tree module which uses these functions is a sample in >samples/livepatch/. If the sample is disabled, the functions are >trimmed and out-of-tree live patches cannot be built. > >Note that live patches are intended to be built out-of-tree. > >Suggested-by: Michal Marek >Signed-off-by: Miroslav Benes Makes sense to me: Acked-by: Jessica Yu >--- > kernel/livepatch/Kconfig | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/kernel/livepatch/Kconfig b/kernel/livepatch/Kconfig >index 045022557936..ec4565122e65 100644 >--- a/kernel/livepatch/Kconfig >+++ b/kernel/livepatch/Kconfig >@@ -10,6 +10,7 @@ config LIVEPATCH > depends on SYSFS > depends on KALLSYMS_ALL > depends on HAVE_LIVEPATCH >+ depends on !TRIM_UNUSED_KSYMS > help > Say Y here if you want to support kernel live patching. > This option has no runtime impact until a kernel "patch" >-- >2.12.2 >