From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752571AbdE0Fnp (ORCPT ); Sat, 27 May 2017 01:43:45 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:32932 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbdE0Fnm (ORCPT ); Sat, 27 May 2017 01:43:42 -0400 Date: Sat, 27 May 2017 07:43:30 +0200 From: Greg Kroah-Hartman To: Badhri Jagan Sridharan Cc: Heikki Krogerus , Guenter Roeck , Oliver Neukum , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4] usb: typec: Add a sysfs node to manage port type Message-ID: <20170527054330.GB28555@kroah.com> References: <20170526204257.9062-1-Badhri@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170526204257.9062-1-Badhri@google.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 26, 2017 at 01:42:57PM -0700, Badhri Jagan Sridharan wrote: > User space applications in some cases have the need to enforce a > specific port type(DFP/UFP/DRP). This change allows userspace to > attempt setting the desired port type. Low level drivers can > however reject the request if the specific port type is not supported. > > Signed-off-by: Badhri Jagan Sridharan > --- > Changelog since v1: > - introduced a new variable port_type in struct typec_port to track > the current port type instead of changing type member in > typec_capability to address Heikki Krogerus comments. > - changed the output format and strings that would be displayed as > suggested by Heikki Krogerus. > > Changelog since v2: > - introduced a new mutex lock to protect port_type for addressing > the race conditions identified by Geunter Roeck > - added typec_port_types_drp for printing port_type when cap->type > is TYPE_PORT_DRP as suggested by Geunter Roeck > - Power role swap and data role swaps would be rejected unless > port port_type == TYPE_PORT_DRP > - port_type_store would return immediately if the current port_type > is same as the new port_type as suggested by Geunter Roeck > > Changelog since v3: > - Moved as much as code outside port_type_lock as suggested by > Geunter Roeck > - Removed Change-Id line from commit message identified by > Greg Kroah-Hartman Ok, this is how you write a changelog for a patch, very nice job! greg k-h