From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750974AbdE1Ma4 (ORCPT ); Sun, 28 May 2017 08:30:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58642 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbdE1Map (ORCPT ); Sun, 28 May 2017 08:30:45 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6B0EDC049D57 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=hdegoede@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 6B0EDC049D57 From: Hans de Goede To: Lee Jones , Chen-Yu Tsai Cc: Hans de Goede , linux-kernel@vger.kernel.org Subject: [PATCH v5 3/7] staging: atomisp: Set step to 0 for mt9m114 menu control Date: Sun, 28 May 2017 14:30:36 +0200 Message-Id: <20170528123040.18555-3-hdegoede@redhat.com> In-Reply-To: <20170528123040.18555-1-hdegoede@redhat.com> References: <20170528123040.18555-1-hdegoede@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Sun, 28 May 2017 12:30:45 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org menu controls are not allowed to have a step size, set step to 0 to fix an oops from the WARN_ON in v4l2_ctrl_new_custom() triggering because of this. Signed-off-by: Hans de Goede --- drivers/staging/media/atomisp/i2c/mt9m114.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/i2c/mt9m114.c b/drivers/staging/media/atomisp/i2c/mt9m114.c index ced175c268d1..3fa915313e53 100644 --- a/drivers/staging/media/atomisp/i2c/mt9m114.c +++ b/drivers/staging/media/atomisp/i2c/mt9m114.c @@ -1499,7 +1499,7 @@ static struct v4l2_ctrl_config mt9m114_controls[] = { .type = V4L2_CTRL_TYPE_MENU, .min = 0, .max = 3, - .step = 1, + .step = 0, .def = 1, .flags = 0, }, -- 2.13.0