From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750866AbdE1SHX (ORCPT ); Sun, 28 May 2017 14:07:23 -0400 Received: from smtpbg202.qq.com ([184.105.206.29]:43767 "EHLO smtpbg202.qq.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750797AbdE1SHW (ORCPT ); Sun, 28 May 2017 14:07:22 -0400 X-QQ-mid: esmtp15t1495994825tr9v3v6ll X-QQ-SSF: A1000000000000708H100000000000R X-QQ-FEAT: EcrU/iQvn3u4tqpvi3g2FvyEpKMzju3zpFK4n6ZycSH9Li/q8edqNd9Ld4Z3/ ua/6v3ScGU1hdcwNYUuK9JKHSrB9JFwWOpwkajPjXwePytGx3u8QiseBlubkB4q24oaIt2I QPHrEl9X4o5PCSMLIIjvTGPxS10g0xmFhzMKQ6G8ESjTy3chBDpur2cACwCGl2mwt4lr8YY 7/haYfxMzPbEHUvv9GsUupr+m8UhXt1tFfbZlbHl4x4uZIETy1lBK5mJWnnF9VkgkauISyp f5qg== X-QQ-GoodBg: 0 From: Chen Guanqiao To: mchehab@kernel.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org Cc: gregkh@linuxfoundation.org, alan@linux.intel.com, fengguang.wu@intel.com, linux-kernel@vger.kernel.org, Chen Guanqiao Subject: [PATCH] staging: atomisp: lm3554: fix sparse warnings(was not declared. Should it be static?) Date: Mon, 29 May 2017 02:06:41 +0800 Message-Id: <20170528180641.9152-1-chen.chenchacha@foxmail.com> X-Mailer: git-send-email 2.11.0 X-QQ-SENDSIZE: 520 Feedback-ID: esmtp:foxmail.com:bgforeign:bgforeign3 X-QQ-Bgrelay: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix "symbol 'xxxxxxx' was not declared. Should it be static?" sparse warnings. Signed-off-by: Chen Guanqiao --- drivers/staging/media/atomisp/i2c/lm3554.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/lm3554.c b/drivers/staging/media/atomisp/i2c/lm3554.c index dd9c9c3ffff7..2b170c07aaba 100644 --- a/drivers/staging/media/atomisp/i2c/lm3554.c +++ b/drivers/staging/media/atomisp/i2c/lm3554.c @@ -497,7 +497,7 @@ static const struct v4l2_ctrl_ops ctrl_ops = { .g_volatile_ctrl = lm3554_g_volatile_ctrl }; -struct v4l2_ctrl_config lm3554_controls[] = { +static const struct v4l2_ctrl_config lm3554_controls[] = { { .ops = &ctrl_ops, .id = V4L2_CID_FLASH_TIMEOUT, @@ -825,7 +825,7 @@ static int lm3554_gpio_uninit(struct i2c_client *client) return 0; } -void *lm3554_platform_data_func(struct i2c_client *client) +static void *lm3554_platform_data_func(struct i2c_client *client) { static struct lm3554_platform_data platform_data; -- 2.11.0