From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751146AbdE2VrF (ORCPT ); Mon, 29 May 2017 17:47:05 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:54924 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750886AbdE2VrE (ORCPT ); Mon, 29 May 2017 17:47:04 -0400 Date: Mon, 29 May 2017 23:45:51 +0200 From: Karsten Merker To: Jagan Teki Cc: Maxime Ripard , Chen-Yu Tsai , Sean Wang , Icenowy Zheng , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Michael Trimarchi , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Jagan Teki Subject: Re: [linux-sunxi] [PATCH 1/3] ARM: dts: sun7i-a20: Rename bananapi as bananapi m1 Message-ID: <20170529214551.GA1990@excalibur.cnev.de> References: <1496086228-2806-1-git-send-email-jagan@openedev.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1496086228-2806-1-git-send-email-jagan@openedev.com> X-No-Archive: yes User-Agent: Mutt/1.5.23 (2014-03-12) X-Provags-ID: V03:K0:k8df9tBjKl77PNdUluOwNRTVPa3Yn3DQlCqcGUzV6AzBLBc/8fs yEmdPOIGq7K2RQJQc8k3ZcNgFy5BLZw8r8Bd9cG6mJSg6febzGXzbghUCbomtgHu8D1fxdz 8uZVuhifjhGcMrrWjpRWsx9p4cXxMX8zuruf/RPhpSIG7ycq45B4KkNqWA435hHTzw9IUwI a8eu3DrYEwyY+EMGv1/9A== X-UI-Out-Filterresults: notjunk:1;V01:K0:VzwTwRcIly8=:OW2szoNWI9iFwLnFuoJIxE lYglepg4qHkze6PuwDvwN+LmBG4+V5H9Mi/G7o89D3gs8kbXLSFdqdrKBgJKIsgMo1jdaTCcb WXx/mw+z9Iu0K0Gzq/4GeITvuhw4fFItw1k1eKhv7wUOjNZ4j6XBjdtmSVq8gM1HZLcVWqiYQ 1dKHl4SEREVP75DmPLv/V4hJQR2tzC6YgaN+6fNo4EEX/4O4qaWNgfTSvUwg4DIB2Nc37Zq5g cWFcWiKi9imAIW6JCBH8nV+WLIjeKRSPn2Yqq4Uly7EMua1QOPdGDPz6tfMZkRfIIn2pythIm xGmPOavdZd4wgAC+ysngk62NvwbbkN0OywshkqBGmdvgxmO2dvGXyRjcY0bxCNYqKxh47VE+A qw/854WxMMXCW0soKl5VrwmFyTSDGUSQkBxBwUxNbj1sHYy5/t0EbUBL0M3J82uFMS7I5ptE3 qRiY5KwMHUB2G18X/GuQmB2hzpYj5sevC0gW+IANa/fGSPa5uoPk8aeTUIpYk0ewdectPWPOa K5yTN81QC9B124NR9LSys7hX5KlKs/9kc2Mwuz8kQKVG4J4jQCRCb1busz1vbZoJEHhSHcTsr ljZHaoUx1pa++1LYQ7B7LOe+0CN8ivuMNRBomBWaenkM3BKeRAzxvSrbp9c6iwJKKigy7Tq2/ 20u+zLhi8STYPqVA0Twj9qPgEieslpmhOHxfSyzC4NO8X5v2gGDegcA8p12F1Y5wEMq0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 29, 2017 at 07:30:26PM +0000, Jagan Teki wrote: > From: Jagan Teki > > from BPI(BIPAI KEJI LIMITED) products the Bananapi board > is named as 'Bananapi M1' and this is the starting > bananapi board from M1 series. > > So rename dts and suffix 'M1' on model for the same, > so-that next sequence on bananapi starts like M1 Plus, M2 and so..on > > Signed-off-by: Jagan Teki > --- > Note: Bananapi BPI product site > http://www.banana-pi.org/product.html > > arch/arm/boot/dts/Makefile | 2 +- > arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts | 286 ++++++++++++++++++++++++++++ > arch/arm/boot/dts/sun7i-a20-bananapi.dts | 286 ---------------------------- > 3 files changed, 287 insertions(+), 287 deletions(-) > create mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts > delete mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 45c6e65..1b086f0 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -851,7 +851,7 @@ dtb-$(CONFIG_MACH_SUN6I) += \ > sun6i-a31s-sinovoip-bpi-m2.dtb \ > sun6i-a31s-yones-toptech-bs1078-v2.dtb > dtb-$(CONFIG_MACH_SUN7I) += \ > - sun7i-a20-bananapi.dtb \ > + sun7i-a20-bananapi-m1.dtb \ > sun7i-a20-bananapi-m1-plus.dtb \ > sun7i-a20-bananapro.dtb \ > sun7i-a20-cubieboard2.dtb \ > diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts b/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts > new file mode 100644 > index 0000000..8b97b89 > --- /dev/null > +++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts > @@ -0,0 +1,286 @@ > +/* > + * Copyright 2014 Hans de Goede > + * > + * Hans de Goede [...] > +/dts-v1/; > +#include "sun7i-a20.dtsi" > +#include "sunxi-common-regulators.dtsi" > + > +#include > +#include > + > +/ { > + model = "LeMaker Banana Pi M1"; > + compatible = "lemaker,bananapi", "allwinner,sun7i-a20"; [...] > diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts > deleted file mode 100644 > index ed2f35a..0000000 > --- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts > +++ /dev/null NACK! Please neither rename the dts nor change the model string. Such a change would make newer kernels unusable on many existing installations without manual fixups by the end user. Linux distributions use databases with model-specific setup information (such as the dtb file name, the platform-specific bootscript to use, usable kernel flavours (lpae or non-lpae), etc.) on kernel installations and kernel upgrades, and those use the model string as their key for finding the relevant information. If you change either the dts file name or the model string inside the dts, you'll effectively break the proper installation of newer kernel versions on existing end user systems. For an example of such a database, please cf. https://anonscm.debian.org/cgit/d-i/flash-kernel.git/tree/db/all.db#n731 Regards, Karsten -- Gem. Par. 28 Abs. 4 Bundesdatenschutzgesetz widerspreche ich der Nutzung sowie der Weitergabe meiner personenbezogenen Daten für Zwecke der Werbung sowie der Markt- oder Meinungsforschung.