From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751932AbdE3PJn (ORCPT ); Tue, 30 May 2017 11:09:43 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:51996 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbdE3PJk (ORCPT ); Tue, 30 May 2017 11:09:40 -0400 Date: Tue, 30 May 2017 11:09:33 -0400 (EDT) Message-Id: <20170530.110933.385314582905902944.davem@davemloft.net> To: andrew@lunn.ch Cc: vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, f.fainelli@gmail.com Subject: Re: [PATCH net-next 2/7] net: dsa: remove useless rcv copy in DSA tree From: David Miller In-Reply-To: <20170530150531.GD22758@lunn.ch> References: <20170530142131.23568-1-vivien.didelot@savoirfairelinux.com> <20170530142131.23568-3-vivien.didelot@savoirfairelinux.com> <20170530150531.GD22758@lunn.ch> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 30 May 2017 07:27:58 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrew Lunn Date: Tue, 30 May 2017 17:05:31 +0200 > On Tue, May 30, 2017 at 10:21:26AM -0400, Vivien Didelot wrote: >> The dsa_switch_tree holds a copy of the rcv member of the dsa_device_ops >> structure. dst->rcv is always assigned to dst->tag_ops->rcv. Remove this >> useless copy. >> >> Signed-off-by: Vivien Didelot >> --- >> include/net/dsa.h | 4 ---- >> net/dsa/dsa.c | 4 ++-- >> net/dsa/dsa2.c | 2 -- >> net/dsa/legacy.c | 2 -- >> 4 files changed, 2 insertions(+), 10 deletions(-) >> >> diff --git a/include/net/dsa.h b/include/net/dsa.h >> index cb5d668b265d..4b82766715e9 100644 >> --- a/include/net/dsa.h >> +++ b/include/net/dsa.h >> @@ -126,10 +126,6 @@ struct dsa_switch_tree { >> * protocol to use. >> */ >> struct net_device *master_netdev; >> - struct sk_buff * (*rcv)(struct sk_buff *skb, >> - struct net_device *dev, >> - struct packet_type *pt, >> - struct net_device *orig_dev); >> >> /* >> * Original copy of the master netdev ethtool_ops >> diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c >> index 7a8a0358299b..861dc0e5020d 100644 >> --- a/net/dsa/dsa.c >> +++ b/net/dsa/dsa.c >> @@ -29,7 +29,7 @@ >> >> bool dsa_uses_tagged_protocol(struct dsa_switch_tree *dst) >> { >> - return !!dst->rcv; >> + return dst->tag_ops && dst->tag_ops->rcv; > > This makes the hot path more expensive. The copy is probably worth it > in terms of performance. Agreed.