From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751053AbdE3SIO (ORCPT ); Tue, 30 May 2017 14:08:14 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:54260 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821AbdE3SIN (ORCPT ); Tue, 30 May 2017 14:08:13 -0400 Date: Tue, 30 May 2017 14:08:11 -0400 (EDT) Message-Id: <20170530.140811.495484137447763709.davem@davemloft.net> To: arnd@arndb.de Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions From: David Miller In-Reply-To: <20170529125612.110244-1-arnd@arndb.de> References: <20170529125612.110244-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 30 May 2017 10:26:36 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Mon, 29 May 2017 14:56:01 +0200 > 'static' was not enough, the helpers must be 'static inline' > > net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' defined but not used [-Werror=unused-function] > net/dsa/mv88e6xxx/global2.h:117:12: error: 'mv88e6xxx_g2_pvt_write' defined but not used [-Werror=unused-function] > > Fixes: c21fbe29f858 ("net: dsa: mv88e6xxx: Add missing static to stub functions") > Signed-off-by: Arnd Bergmann Applied.