From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751244AbdE3SJm (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 May 2017 14:09:42 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:54284 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750761AbdE3SJl (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 May 2017 14:09:41 -0400
Date: Tue, 30 May 2017 14:09:38 -0400 (EDT)
Message-Id: <20170530.140938.195927218396234401.davem@davemloft.net>
To: arnd@arndb.de
Cc: saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com,
        mohamad@mellanox.com, danielj@mellanox.com, eli@mellanox.com,
        avivh@mellanox.com, huyn@mellanox.com, artemyko@mellanox.com,
        netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net/mlx5: avoid build warning for uniprocessor
From: David Miller <davem@davemloft.net>
In-Reply-To: <20170529130030.244337-1-arnd@arndb.de>
References: <20170529130030.244337-1-arnd@arndb.de>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 30 May 2017 10:28:04 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 29 May 2017 15:00:17 +0200

> Building the driver with CONFIG_SMP disabled results in a harmless
> warning:
> 
> ethernet/mellanox/mlx5/core/main.c: In function 'mlx5_irq_set_affinity_hint':
> ethernet/mellanox/mlx5/core/main.c:615:6: error: unused variable 'irq' [-Werror=unused-variable]
> 
> It's better to express the conditional compilation using IS_ENABLED()
> here, as that lets the compiler see what the intented use for the variable
> is, and that it can be silently discarded.
> 
> Fixes: b665d98edc9a ("net/mlx5: Tolerate irq_set_affinity_hint() failures")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thank you.