From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751060AbdE3GYA (ORCPT ); Tue, 30 May 2017 02:24:00 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:63462 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbdE3GX5 (ORCPT ); Tue, 30 May 2017 02:23:57 -0400 Date: Tue, 30 May 2017 08:22:44 +0200 From: Karsten Merker To: Jagan Teki Cc: Karsten Merker , Jagan Teki , Maxime Ripard , Chen-Yu Tsai , Sean Wang , Icenowy Zheng , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Michael Trimarchi , "linux-arm-kernel@lists.infradead.org" , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-sunxi , Jagan Teki Subject: Re: [linux-sunxi] [PATCH 1/3] ARM: dts: sun7i-a20: Rename bananapi as bananapi m1 Message-ID: <20170530062244.GA1962@excalibur.cnev.de> References: <1496086228-2806-1-git-send-email-jagan@openedev.com> <20170529214551.GA1990@excalibur.cnev.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-No-Archive: yes User-Agent: Mutt/1.5.23 (2014-03-12) X-Provags-ID: V03:K0:ap17zJ+A/wKoBkwbuuyDt5PgYIOndwvuE3TsnC3QbpBaqCOSF7O ppdSuAX8HTXePwqPFTcQhez8Aaiubr1AXfC2Zrm5YU2MLB7SjQc/R3eXIiN9BTpoVwHSEVJ f9fEyPWa/yykC8HqWRM/Q/ggTWUWN/1dcC0TIhV0kU5foONv6rBCCR7Je10djNO1aosWj3A 4WINTBK9twr9IoFxyGkeg== X-UI-Out-Filterresults: notjunk:1;V01:K0:7I3UonIk0pY=:ee9aGmDcubM5Ss0IvHZwO5 zC8uczaBONGTKvp/FvoTlxP4LXl+1KEcpBsr9G2bdRiCPNMqPW6MXB7oUrPiuT5XqGr8Y5W0/ +dxZELYCfKvqudJH2NczBXEX5RWRcMn7JFA99zjyDELOFPg1/eKZ7fBTnTF27sFmBbVYDFwI/ 396jGnBQ4XMto6bfaZMsNk6h8TKK5IzTJzXpOT37yE1WJjiooR6SjuiCW4Fk9yaPEUYmmXjdd bo5A2V8ePovA9MrszV7O/7LwIOWrTqduETZfH3V650OBE8F4Vv/LyH0m/EH8spMxBNOzL1VbN XDysJZ7W1vvl4xHZfaI/a6KM738TgVV89ppN0n3wxFkFBawR+0gJlCIi0d3XQqrEAij+QaUCq 5vPL6IZfIO+pUONL/z09iNaIViDT8LlCcp6b/gInsklTIzDuuOYfKn+8N185bG85mnG5YolQy kKXAEZJi0sfwRsqK+oeCpeHzUWMDpknLyJXuFQSMlCDzO/FRmNu10v9z7ZdM7G3pp8wZ4ZWGi VUi8lrz7Nq6qQT60yV3HaFJFDlxKL0Otxa7NRpehUcCxXFL0SNOWIPfiX9ChHb/sa3ha/1Gv8 ASUmtft3Ek0oXPFmDQAidphwiAoIoSb4lcRmT4QR9vKnAoDIiXZX0CqHYE4dd2fswLfkNgxkY 7D06pnGtQ3KWflAOgH//nlIw9sqrkmY2MIHR5dRtJgqK61b4OO/eX1olkvZUkl6l9kQc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 30, 2017 at 10:00:49AM +0530, Jagan Teki wrote: > On Tue, May 30, 2017 at 3:15 AM, Karsten Merker wrote: > > On Mon, May 29, 2017 at 07:30:26PM +0000, Jagan Teki wrote: > >> From: Jagan Teki > >> > >> from BPI(BIPAI KEJI LIMITED) products the Bananapi board > >> is named as 'Bananapi M1' and this is the starting > >> bananapi board from M1 series. > >> > >> So rename dts and suffix 'M1' on model for the same, > >> so-that next sequence on bananapi starts like M1 Plus, M2 and so..on > >> > >> Signed-off-by: Jagan Teki > >> --- > >> Note: Bananapi BPI product site > >> http://www.banana-pi.org/product.html > >> > >> arch/arm/boot/dts/Makefile | 2 +- > >> arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts | 286 ++++++++++++++++++++++++++++ > >> arch/arm/boot/dts/sun7i-a20-bananapi.dts | 286 ---------------------------- > >> 3 files changed, 287 insertions(+), 287 deletions(-) > >> create mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts > >> delete mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi.dts > >> > >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > >> index 45c6e65..1b086f0 100644 > >> --- a/arch/arm/boot/dts/Makefile > >> +++ b/arch/arm/boot/dts/Makefile > >> @@ -851,7 +851,7 @@ dtb-$(CONFIG_MACH_SUN6I) += \ > >> sun6i-a31s-sinovoip-bpi-m2.dtb \ > >> sun6i-a31s-yones-toptech-bs1078-v2.dtb > >> dtb-$(CONFIG_MACH_SUN7I) += \ > >> - sun7i-a20-bananapi.dtb \ > >> + sun7i-a20-bananapi-m1.dtb \ > >> sun7i-a20-bananapi-m1-plus.dtb \ > >> sun7i-a20-bananapro.dtb \ > >> sun7i-a20-cubieboard2.dtb \ > >> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts b/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts > >> new file mode 100644 > >> index 0000000..8b97b89 > >> --- /dev/null > >> +++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1.dts > >> @@ -0,0 +1,286 @@ > >> +/* > >> + * Copyright 2014 Hans de Goede > >> + * > >> + * Hans de Goede > > [...] > >> +/dts-v1/; > >> +#include "sun7i-a20.dtsi" > >> +#include "sunxi-common-regulators.dtsi" > >> + > >> +#include > >> +#include > >> + > >> +/ { > >> + model = "LeMaker Banana Pi M1"; > >> + compatible = "lemaker,bananapi", "allwinner,sun7i-a20"; > > [...] > >> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts > >> deleted file mode 100644 > >> index ed2f35a..0000000 > >> --- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts > >> +++ /dev/null > > > > NACK! > > > > Please neither rename the dts nor change the model string. Such a > > change would make newer kernels unusable on many existing > > installations without manual fixups by the end user. Linux > > distributions use databases with model-specific setup information > > (such as the dtb file name, the platform-specific bootscript to > > use, usable kernel flavours (lpae or non-lpae), etc.) on kernel > > installations and kernel upgrades, and those use the model string > > as their key for finding the relevant information. If you change > > either the dts file name or the model string inside the dts, > > you'll effectively break the proper installation of newer kernel > > versions on existing end user systems. > > I understand your concerns about distribution change, but with new > change in 'bananapi' brand owned by BIPAI KEJI(BPI) the model must > need to update and this is not technically as Bananapi board it is > Bananapi M1 [1] > > These are generic changes based on the hardware vendor info. > > [1] http://www.banana-pi.org/m1.html Hello Jagan, I have to disagree here. Whatever BIPAI KEJI(BPI) chooses to name their products today or in the future doesn't change history. The "original" Banana Pi was sold under the LeMaker brand and it was named "Banana Pi" and not "Banana Pi M1". The fact that LeMaker has stopped selling their Banana Pi board and BIPAI KEJI(BPI) (a different company than LeMaker!) now sells a board that is compatible to the original "LeMaker Banana Pi" under the name "Banana Pi M1" (and not "LeMaker Banana Pi M1" as you claim in your modified dts) doesn't matter at all for an existing dts and is in no way a valid reason to make an incompatible change that breaks existing systems. If you wanted to add a new (technically identical) dts with a different model string under a new dts file name and keep the existing one unchanged, I would find that unneccessary but at least acceptable insofar as it wouldn't break existing end user systems, but breaking existing systems in the wild is clearly unacceptable. I assume that the kernel dts maintainers would probably still object to such an addition as it is unneccessary from a purely technical point of view if the boards are 100% compatible, but that would of course be their decision to make. Regards, Karsten -- Gem. Par. 28 Abs. 4 Bundesdatenschutzgesetz widerspreche ich der Nutzung sowie der Weitergabe meiner personenbezogenen Daten für Zwecke der Werbung sowie der Markt- oder Meinungsforschung.