From: Rakesh Pandit <rakesh@tuxera.com>
To: Christoph Hellwig <hch@lst.de>
Cc: <linux-nvme@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
"Jens Axboe" <axboe@fb.com>, Sagi Grimberg <sagi@grimberg.me>,
Andy Lutomirski <luto@kernel.org>,
Keith Busch <keith.busch@intel.com>
Subject: Re: [PATCH 1/1] nvme: fix nvme_remove going to uninterruptible sleep for ever
Date: Tue, 30 May 2017 10:18:50 +0300 [thread overview]
Message-ID: <20170530071850.GA2713@hercules.tuxera.com> (raw)
In-Reply-To: <20170529175839.GC25061@lst.de>
On Mon, May 29, 2017 at 07:58:39PM +0200, Christoph Hellwig wrote:
> On Mon, May 29, 2017 at 09:29:54AM +0300, Rakesh Pandit wrote:
> > Once controller is in DEAD or DELETING state a call to delete_destroy
> > from nvme_uninit_ctrl results in setting the latency tolerance via
> > nvme_set_latency_tolerance callback even though queues have already
> > been killed. This in turn leads the PID to go into uninterruptible
> > sleep and prevents removal of nvme controller from completion. The
> > stack trace is:
...
>
> What do you think about moving this into the beginning of
> nvme_configure_apst instead? And please add a comment while you're
> at it.
Thanks, makes sense. I have posted V2.
prev parent reply other threads:[~2017-05-30 7:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 6:29 Rakesh Pandit
2017-05-29 17:58 ` Christoph Hellwig
2017-05-30 7:18 ` Rakesh Pandit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530071850.GA2713@hercules.tuxera.com \
--to=rakesh@tuxera.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=luto@kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®