From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751437AbdE3JQF (ORCPT ); Tue, 30 May 2017 05:16:05 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:61931 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992AbdE3JQD (ORCPT ); Tue, 30 May 2017 05:16:03 -0400 From: Arnd Bergmann To: Ingo Molnar , x86@kernel.org Cc: Arnd Bergmann , "H. Peter Anvin" , Thomas Gleixner , Kees Cook , Baoquan He , Thomas Garnier , Dave Jiang , linux-kernel@vger.kernel.org Subject: [PATCH] x86/KASLR: use the right memcpy Date: Tue, 30 May 2017 11:14:17 +0200 Message-Id: <20170530091446.1000183-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:+1pOeInaujirOLlnHuNpB41jKmDSbQJqqCFHjFsylHOv+lRilPx rBvKnFQBBg0r+ifCYGQ5dlxo05qhFukJjKoVhrKH6YDdknHuC03LwyVZnkbJUznUin+LUG2 6GjpN9OuKmUUqsH8bgNZ1LLUWT7L/xl9t1lXIuqImLxvjjtD+pi0By8knrYy30fuk5KPD09 bW392I8NbDni281vpnwhw== X-UI-Out-Filterresults: notjunk:1;V01:K0:QjdFQw7T2EE=:61M1M7mOriqJnUfjoGjkdI xHzDjIBGciublsADzPGdvRX/rWGCKaeDAe+IC3ikx1v5UINxE/JB5ocAA6OHufs4CnNUXtdeb btdEQA86QGSTccmfp2weEUZMj1sqVf+MQRb/dB1K3RBA2UY3cHmUN9Jbxfz8zdgHZPAIF7+3W KWKng1glbkOOxDhPpR//sZFHvf3h/xZ2uN7NZZN5jHj/DT//WOTwkyREA0nKGdHfOrEbExqFZ f0tE3sfxRVqZne4bAt4E8jEf647HgOuKuZYv0wdHuE8StdJxrX2dWVYzqIS4GxNeRSvy+/2Xj fS4vot2gP0MuhTPdcbQTB9lQWwcTsVudsabS8EpI60e0u4R8nhCcJ2WWv0X+8McZUrcBwcILY AAGY4PP3wZAphOnMVo3blfryoNh7d21cgfg5ZpveOXBuHQgJlLAdk8EuYNOCcS2h2tKofPzQP eXoX1OZRsuBHaV59Gc0U0iTPvbnE8tDzJ4/ekyKsVrK1tQwmo7N39sBCH2iNpKOhoueZTZCG6 ThtSiaHMmLfFdWv+XsTokTK+FFykW1+JrITfYnBEiT8cXxuB/VSpLtonJf9davNjPnI78Tzxz oq7isK1aRkT0Y8bt2J9KHSyo3dat/Eil1oc4Qx6n3KjXwPJfWONKnXBJS5AT6SSyalYv6YB8b aW4U+sjb86J1E+8J3mw0GfXakW0RVhno7yEpsEJR2acVfPBo94Mf4BDUcZPjkHSX8PsA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The decompressor has its own implementation of the string functions, but has to include the right header to get those, while implicitly including linux/string.h may result in a link error: arch/x86/boot/compressed/kaslr.o: In function `choose_random_location': kaslr.c:(.text+0xf51): undefined reference to `_mmx_memcpy' This has appeared now as kaslr started using memcpy. Other files in the decompressor already do the same thing. Fixes: d52e7d5a952c ("x86/KASLR: Parse all 'memmap=' boot option entries") Signed-off-by: Arnd Bergmann --- arch/x86/boot/compressed/kaslr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c index e0eba12bffe7..fe318b44f7b8 100644 --- a/arch/x86/boot/compressed/kaslr.c +++ b/arch/x86/boot/compressed/kaslr.c @@ -30,6 +30,7 @@ #include "misc.h" #include "error.h" +#include "../string.h" #include #include -- 2.9.0