From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751717AbdE3J3U (ORCPT ); Tue, 30 May 2017 05:29:20 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:60637 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751695AbdE3J3Q (ORCPT ); Tue, 30 May 2017 05:29:16 -0400 From: Arnd Bergmann To: Kishon Vijay Abraham I Cc: Yuvaraj Kumar C D , Girish K S , Vasanth Ananthan , Arnd Bergmann , Jaehoon Chung , Krzysztof Kozlowski , linux-kernel@vger.kernel.org Subject: [PATCH] PHY: Exynos: fix I2C dependency for Exynos5250 SATA Date: Tue, 30 May 2017 11:28:25 +0200 Message-Id: <20170530092858.1351047-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:ygztqZiKzQTcehbp91nONlT1PnzAo/UYxz4n9ByD0LFQeIZyivT EcpP6iF2P9FAcI+gVPYjoitrhpbjw1Jeamwl/+DuZiNoycVOHpM9PYVrWrccVdJtEFarczr aaRhRZUZ3Z6B/D26P3pdhlS5PxIkWdPw0iAQbY98QeTH3gmJyahPdVraPMZn8pn9vR8Ydji 8j4dm7b1XUlHUnbbji4VA== X-UI-Out-Filterresults: notjunk:1;V01:K0:BGJCDMR15IA=:2etMf8qXHGUpqRIqkBKR9g t0/39st2aN6Vcr/d1mk1rpy1yV9vHt5SF2jaCvFRp+Nmjx8ZzJzwMNhhxHJjXlQHkMxAkhOnW WLEf62z/jfnpmL3AAblyrPud2n2h7Tn/kv1T2ceNpQqZ0m7ZG/joqZ8ob5U//B6aFMJt1Mkjw CN7mOAKDOuo/1g3Yyez96+jN4E79z9SoMC61VyYyWENIm/MKNjwX2ajDHfeN/Y+O425E2/Mib ZYFD3zi23JrqXm2EDedCzR6+Akm9owzGEdv1pwQXBZ1KaNzyAhRU0iwSfLOQza7lK1AyOKIpM R+bIvlrAFnMl+3/h+tGvvoGyZZvLMI+hdrEfYneqlKoqLwJMlg/C3zBDj/4R2Mv598EIZQ5tV uuiUNakIR5NpXtp/j3kqtO9IqKNaxdO5rOfJQZs1+BumHd3hbNaW6BJPNj2kpGbMrEmu37L4G 6PeUsDKvSE/mY79tRjzqltcAuyWpNF49iY4J3R3oRl5GqRVWt4dy6yNnaRB2mjeY5j7gb5bXp IdC2QRTEAm3wMc76MLZCtWQldAB1estHPRagYV99Pr3jPnXUPme7lidStA49sutnq4G4fFyIY XzktKGEzuUTAc6GV94VfRq3quEmO7KPdELT48HqjO1wb0QPuA15D1uLoQmg0jpWo96coiLRs5 kpaCF95laKIvtiroryg7dfmQQUl1xORdww5wU/RTSRxylGgCWWd9cTPE6HabFGhCepE0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Device drivers should not 'select' other subsystems, but rather use 'depends on', to avoid Kconfig dependency loops. This one even selects a particular I2C host driver for no reason, so we can remove the select of that particular driver, and turn the I2C 'select' into 'depends on'. Fixes: bcff4cba41bc ("PHY: Exynos: Add Exynos5250 SATA PHY driver") Signed-off-by: Arnd Bergmann --- drivers/phy/samsung/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/phy/samsung/Kconfig b/drivers/phy/samsung/Kconfig index b7e0645a7bd9..76475b01780d 100644 --- a/drivers/phy/samsung/Kconfig +++ b/drivers/phy/samsung/Kconfig @@ -83,10 +83,9 @@ config PHY_EXYNOS5250_SATA tristate "Exynos5250 Sata SerDes/PHY driver" depends on SOC_EXYNOS5250 depends on HAS_IOMEM + depends on I2C depends on OF select GENERIC_PHY - select I2C - select I2C_S3C2410 select MFD_SYSCON help Enable this to support SATA SerDes/Phy found on Samsung's -- 2.9.0