From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751220AbdE3JaD (ORCPT ); Tue, 30 May 2017 05:30:03 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:38570 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750904AbdE3JaC (ORCPT ); Tue, 30 May 2017 05:30:02 -0400 Date: Tue, 30 May 2017 10:29:58 +0100 From: Lee Jones To: Benjamin Gaignard Cc: Alexandre Torgue , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/15] mfd: stm32-timers: use devm_of_platform_populate Message-ID: <20170530092958.llo37hjt6c73eww3@dell> References: <1496072763-31209-1-git-send-email-benjamin.gaignard@linaro.org> <1496072763-31209-6-git-send-email-benjamin.gaignard@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1496072763-31209-6-git-send-email-benjamin.gaignard@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 May 2017, Benjamin Gaignard wrote: > Use devm_of_platform_populate() instead of of_platform_populate() > and suppress stm32_timers_remove() which become useless. > > Signed-off-by: Benjamin Gaignard > > CC: Lee Jones > CC: Alexandre Torgue > CC: linux-arm-kernel@lists.infradead.org > CC: linux-kernel@vger.kernel.org > --- > drivers/mfd/stm32-timers.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/stm32-timers.c b/drivers/mfd/stm32-timers.c > index 2182f00..a6675a4 100644 > --- a/drivers/mfd/stm32-timers.c > +++ b/drivers/mfd/stm32-timers.c > @@ -58,14 +58,7 @@ static int stm32_timers_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, ddata); > > - return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); > -} > - > -static int stm32_timers_remove(struct platform_device *pdev) > -{ > - of_platform_depopulate(&pdev->dev); > - > - return 0; > + return devm_of_platform_populate(&pdev->dev); > } > > static const struct of_device_id stm32_timers_of_match[] = { > @@ -76,7 +69,6 @@ static int stm32_timers_remove(struct platform_device *pdev) > > static struct platform_driver stm32_timers_driver = { > .probe = stm32_timers_probe, > - .remove = stm32_timers_remove, > .driver = { > .name = "stm32-timers", > .of_match_table = stm32_timers_of_match, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog