From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751548AbdE3Jaf (ORCPT ); Tue, 30 May 2017 05:30:35 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:38796 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751130AbdE3Jad (ORCPT ); Tue, 30 May 2017 05:30:33 -0400 Date: Tue, 30 May 2017 10:30:29 +0100 From: Lee Jones To: Benjamin Gaignard Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/15] mfd: atmel: use devm_of_platform_populate() Message-ID: <20170530093029.kajtfpl3rk6qz2vx@dell> References: <1496072763-31209-1-git-send-email-benjamin.gaignard@linaro.org> <1496072763-31209-7-git-send-email-benjamin.gaignard@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1496072763-31209-7-git-send-email-benjamin.gaignard@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 May 2017, Benjamin Gaignard wrote: > Use devm_of_platform_populate() to be sure that of_platform_depopulate > is called when removing the driver. > > Signed-off-by: Benjamin Gaignard > > CC: Lee Jones > CC: linux-kernel@vger.kernel.org > --- > drivers/mfd/atmel-flexcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c > index e8e67be..064bde9 100644 > --- a/drivers/mfd/atmel-flexcom.c > +++ b/drivers/mfd/atmel-flexcom.c > @@ -80,7 +80,7 @@ static int atmel_flexcom_probe(struct platform_device *pdev) > > clk_disable_unprepare(clk); > > - return of_platform_populate(np, NULL, NULL, &pdev->dev); > + return devm_of_platform_populate(&pdev->dev); > } > > static const struct of_device_id atmel_flexcom_of_match[] = { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog