From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751639AbdE3JbR (ORCPT ); Tue, 30 May 2017 05:31:17 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:35608 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751002AbdE3JbP (ORCPT ); Tue, 30 May 2017 05:31:15 -0400 Date: Tue, 30 May 2017 10:31:11 +0100 From: Lee Jones To: Benjamin Gaignard Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/15] mfd: fsl-imx25: use devm_of_platform_populate() Message-ID: <20170530093111.cw5d2gxfmcxtgl34@dell> References: <1496072763-31209-1-git-send-email-benjamin.gaignard@linaro.org> <1496072763-31209-10-git-send-email-benjamin.gaignard@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1496072763-31209-10-git-send-email-benjamin.gaignard@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 May 2017, Benjamin Gaignard wrote: > Use devm_of_platform_populate() to be sure that of_platform_depopulate > is called when removing the driver. > > Signed-off-by: Benjamin Gaignard > > CC: Lee Jones > CC: linux-kernel@vger.kernel.org > --- > drivers/mfd/fsl-imx25-tsadc.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/fsl-imx25-tsadc.c b/drivers/mfd/fsl-imx25-tsadc.c > index ac430a3..4258a42 100644 > --- a/drivers/mfd/fsl-imx25-tsadc.c > +++ b/drivers/mfd/fsl-imx25-tsadc.c > @@ -129,7 +129,6 @@ static void mx25_tsadc_setup_clk(struct platform_device *pdev, > static int mx25_tsadc_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > - struct device_node *np = dev->of_node; > struct mx25_tsadc *tsadc; > struct resource *res; > int ret; > @@ -178,9 +177,7 @@ static int mx25_tsadc_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, tsadc); > > - of_platform_populate(np, NULL, NULL, dev); > - > - return 0; > + return devm_of_platform_populate(dev); > } > > static const struct of_device_id mx25_tsadc_ids[] = { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog