From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751753AbdE3Jbo (ORCPT ); Tue, 30 May 2017 05:31:44 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:35275 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751737AbdE3Jbm (ORCPT ); Tue, 30 May 2017 05:31:42 -0400 Date: Tue, 30 May 2017 10:31:38 +0100 From: Lee Jones To: Benjamin Gaignard Cc: Tony Lindgren , linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/15] mfd: palmas: use devm_of_platform_populate() Message-ID: <20170530093138.7bj5toutshey6bdv@dell> References: <1496072763-31209-1-git-send-email-benjamin.gaignard@linaro.org> <1496072763-31209-12-git-send-email-benjamin.gaignard@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1496072763-31209-12-git-send-email-benjamin.gaignard@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 May 2017, Benjamin Gaignard wrote: > Use devm_of_platform_populate() to be sure that of_platform_depopulate > is called when removing the driver. > > Signed-off-by: Benjamin Gaignard > > CC: Tony Lindgren > CC: Lee Jones > CC: linux-kernel@vger.kernel.org > --- > drivers/mfd/palmas.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c > index 9103aff..3922a93 100644 > --- a/drivers/mfd/palmas.c > +++ b/drivers/mfd/palmas.c > @@ -676,7 +676,7 @@ static int palmas_i2c_probe(struct i2c_client *i2c, > * otherwise continue and add devices using mfd helpers. > */ > if (node) { > - ret = of_platform_populate(node, NULL, NULL, &i2c->dev); > + ret = devm_of_platform_populate(&i2c->dev); > if (ret < 0) { > goto err_irq; > } else if (pdata->pm_off && !pm_power_off) { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog