From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751769AbdE3JcJ (ORCPT ); Tue, 30 May 2017 05:32:09 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:34886 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750965AbdE3JcH (ORCPT ); Tue, 30 May 2017 05:32:07 -0400 Date: Tue, 30 May 2017 10:32:03 +0100 From: Lee Jones To: Benjamin Gaignard Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/15] mfd: qcom-spmi-pmic: use devm_of_platform_populate() Message-ID: <20170530093203.fcnhpcexgdzpykl7@dell> References: <1496072763-31209-1-git-send-email-benjamin.gaignard@linaro.org> <1496072763-31209-13-git-send-email-benjamin.gaignard@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1496072763-31209-13-git-send-email-benjamin.gaignard@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 May 2017, Benjamin Gaignard wrote: > Usage of devm_of_platform_populate() simplify driver code > by allowing to delete pmic_spmi_remove(). > > Signed-off-by: Benjamin Gaignard > > CC: Lee Jones > CC: linux-kernel@vger.kernel.org > --- > drivers/mfd/qcom-spmi-pmic.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c > index 8653e8b..2022bdf 100644 > --- a/drivers/mfd/qcom-spmi-pmic.c > +++ b/drivers/mfd/qcom-spmi-pmic.c > @@ -120,7 +120,6 @@ static void pmic_spmi_show_revid(struct regmap *map, struct device *dev) > > static int pmic_spmi_probe(struct spmi_device *sdev) > { > - struct device_node *root = sdev->dev.of_node; > struct regmap *regmap; > > regmap = devm_regmap_init_spmi_ext(sdev, &spmi_regmap_config); > @@ -131,19 +130,13 @@ static int pmic_spmi_probe(struct spmi_device *sdev) > if (sdev->usid % 2 == 0) > pmic_spmi_show_revid(regmap, &sdev->dev); > > - return of_platform_populate(root, NULL, NULL, &sdev->dev); > -} > - > -static void pmic_spmi_remove(struct spmi_device *sdev) > -{ > - of_platform_depopulate(&sdev->dev); > + return devm_of_platform_populate(&sdev->dev); > } > > MODULE_DEVICE_TABLE(of, pmic_spmi_id_table); > > static struct spmi_driver pmic_spmi_driver = { > .probe = pmic_spmi_probe, > - .remove = pmic_spmi_remove, > .driver = { > .name = "pmic-spmi", > .of_match_table = pmic_spmi_id_table, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog