From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751785AbdE3Jc2 (ORCPT ); Tue, 30 May 2017 05:32:28 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:34582 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751780AbdE3JcZ (ORCPT ); Tue, 30 May 2017 05:32:25 -0400 Date: Tue, 30 May 2017 10:32:20 +0100 From: Lee Jones To: Benjamin Gaignard Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 13/15] mfd: smsc-ece: use devm_of_platform_populate() Message-ID: <20170530093220.5jufyjbg5q5olbft@dell> References: <1496072763-31209-1-git-send-email-benjamin.gaignard@linaro.org> <1496072763-31209-14-git-send-email-benjamin.gaignard@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1496072763-31209-14-git-send-email-benjamin.gaignard@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 May 2017, Benjamin Gaignard wrote: > Use devm_of_platform_populate() to be sure that of_platform_depopulate > is called when removing the driver. > > Signed-off-by: Benjamin Gaignard > > CC: Lee Jones > CC: linux-kernel@vger.kernel.org > --- > drivers/mfd/smsc-ece1099.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/smsc-ece1099.c b/drivers/mfd/smsc-ece1099.c > index 1f40baf..93a8297 100644 > --- a/drivers/mfd/smsc-ece1099.c > +++ b/drivers/mfd/smsc-ece1099.c > @@ -69,8 +69,7 @@ static int smsc_i2c_probe(struct i2c_client *i2c, > > #ifdef CONFIG_OF > if (i2c->dev.of_node) > - ret = of_platform_populate(i2c->dev.of_node, > - NULL, NULL, &i2c->dev); > + ret = devm_of_platform_populate(&i2c->dev); > #endif > > return ret; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog