From: Lee Jones <lee.jones@linaro.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Sascha Weisenberger <sascha.weisenberger@siemens.com>
Subject: Re: [PATCH v3 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency
Date: Tue, 30 May 2017 11:13:50 +0100 [thread overview]
Message-ID: <20170530101350.ay6eotxzfttpnfrx@dell> (raw)
In-Reply-To: <781e53b10a5cb589fbe0d1a92e90f9c3b5759499.1496132260.git.jan.kiszka@siemens.com>
On Tue, 30 May 2017, Jan Kiszka wrote:
> Avoids reimplementation of DMI matching in intel_quark_i2c_setup.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mfd/intel_quark_i2c_gpio.c | 33 +++++++++++++--------------------
> 1 file changed, 13 insertions(+), 20 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/intel_quark_i2c_gpio.c b/drivers/mfd/intel_quark_i2c_gpio.c
> index 7946d6e38b87..050061320377 100644
> --- a/drivers/mfd/intel_quark_i2c_gpio.c
> +++ b/drivers/mfd/intel_quark_i2c_gpio.c
> @@ -58,19 +58,18 @@ struct intel_quark_mfd {
> struct clk_lookup *i2c_clk_lookup;
> };
>
> -struct i2c_mode_info {
> - const char *name;
> - unsigned int i2c_scl_freq;
> -};
> -
> -static const struct i2c_mode_info platform_i2c_mode_info[] = {
> +static const struct dmi_system_id dmi_platform_info[] = {
> {
> - .name = "Galileo",
> - .i2c_scl_freq = 100000,
> + .matches = {
> + DMI_EXACT_MATCH(DMI_BOARD_NAME, "Galileo"),
> + },
> + .driver_data = (void *)100000,
> },
> {
> - .name = "GalileoGen2",
> - .i2c_scl_freq = 400000,
> + .matches = {
> + DMI_EXACT_MATCH(DMI_BOARD_NAME, "GalileoGen2"),
> + },
> + .driver_data = (void *)400000,
> },
> {}
> };
> @@ -160,8 +159,7 @@ static void intel_quark_unregister_i2c_clk(struct device *dev)
>
> static int intel_quark_i2c_setup(struct pci_dev *pdev, struct mfd_cell *cell)
> {
> - const char *board_name = dmi_get_system_info(DMI_BOARD_NAME);
> - const struct i2c_mode_info *info;
> + const struct dmi_system_id *dmi_id;
> struct dw_i2c_platform_data *pdata;
> struct resource *res = (struct resource *)cell->resources;
> struct device *dev = &pdev->dev;
> @@ -181,14 +179,9 @@ static int intel_quark_i2c_setup(struct pci_dev *pdev, struct mfd_cell *cell)
> /* Normal mode by default */
> pdata->i2c_scl_freq = 100000;
>
> - if (board_name) {
> - for (info = platform_i2c_mode_info; info->name; info++) {
> - if (!strcmp(board_name, info->name)) {
> - pdata->i2c_scl_freq = info->i2c_scl_freq;
> - break;
> - }
> - }
> - }
> + dmi_id = dmi_first_match(dmi_platform_info);
> + if (dmi_id)
> + pdata->i2c_scl_freq = (uintptr_t)dmi_id->driver_data;
>
> cell->platform_data = pdata;
> cell->pdata_size = sizeof(*pdata);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-05-30 10:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 8:17 [PATCH v3 0/2] mfd: intel_quark_i2c_gpio: Refactor and support for IOT2000 Jan Kiszka
2017-05-30 8:17 ` [PATCH v3 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka
2017-05-30 10:13 ` Lee Jones [this message]
2017-05-30 8:17 ` [PATCH v3 2/2] mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform Jan Kiszka
2017-05-30 10:13 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530101350.ay6eotxzfttpnfrx@dell \
--to=lee.jones@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sascha.weisenberger@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®