From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751496AbdE3MEG (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 May 2017 08:04:06 -0400
Received: from mail.free-electrons.com ([62.4.15.54]:49325 "EHLO
        mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750952AbdE3MEF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 May 2017 08:04:05 -0400
Date: Tue, 30 May 2017 14:04:03 +0200
From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <marc.zyngier@arm.com>, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Kumar Gala <galak@codeaurora.org>, Andrew Lunn <andrew@lunn.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Gregory Clement <gregory.clement@free-electrons.com>,
        linux-arm-kernel@lists.infradead.org,
        Nadav Haklai <nadavh@marvell.com>, Hanna Hawa <hannah@marvell.com>,
        Yehuda Yitschak <yehuday@marvell.com>,
        Antoine Tenart <antoine.tenart@free-electrons.com>
Subject: Re: [PATCH 4/6] irqchip: irq-mvebu-icu: new driver for Marvell ICU
Message-ID: <20170530120403.GB25456@kwain>
References: <1496135772-20694-1-git-send-email-thomas.petazzoni@free-electrons.com>
 <1496135772-20694-5-git-send-email-thomas.petazzoni@free-electrons.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="gj572EiMnwbLXET9"
Content-Disposition: inline
In-Reply-To: <1496135772-20694-5-git-send-email-thomas.petazzoni@free-electrons.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--gj572EiMnwbLXET9
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Thomas,

Very small comment,

On Tue, May 30, 2017 at 11:16:09AM +0200, Thomas Petazzoni wrote:
> diff --git a/drivers/irqchip/irq-mvebu-icu.c b/drivers/irqchip/irq-mvebu-=
icu.c
[...]
> +#define ICU_INT_CFG(x)          (0x100 + 4 * x)

You should use (x) here, to be safe.

Thanks!
Antoine

--=20
Antoine T=E9nart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

--gj572EiMnwbLXET9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCgAGBQJZLV+yAAoJEFxNi8it27zYl9AP/jerMn6uny77T9hJGZl++uxP
wTvNo4E6CvhUyzscZiYwLMQo7vI/clRxbdRv1yDrnQvRaM9RAz326mnrrc2lU8N6
5E4VgQ2sudYswjztgDDH2t0WiujkvEwrs9K1AXxLr55O/i+3l90K7RjC+vQzQazT
iNgN63sAymJiXDAdgFev/WnT1gj6Qz5RFUIP40F4oYBSfrUc/cqgPgdBZqlIur+n
ON/IDtfN1PRGp98z6TnLqjlMWKg86Wb83t/SYXORGgI4htGsIz+NyknyGhtotf6u
37zaTdDWPnkr784e12MEOs8lBpnKy9KpOJMRVI3dPz1QPRX6IpLcbdh7JCF/Oq9B
+Bkovxv4U8EcfrnQqdeoMlMb1MBJBSktaDlGIA6B7wc8A7HcV4Fp53yFuEL8he9h
1m9e1HI1S3zIF0WE6nczhMo/vHOnB4QBzZulrFyTz5odXfarDTyKym+fJZ6vRp3h
n8lHwmnA9TQhOG0lURFmI6Du/HnjhO5yrxPENK5ADPSDQH6Xxzb1NUDgn72Kz2kA
INGi7SZYEgEy9mUPKyrdoBVxnP/z22+R1KzevbtxcrATR5/0JKwAGrt6DRPzimfS
AcMijxR5rpP4cw2+RmgvbWmEdpbG2qvcuUveemWcGlMIjmtFFuEG2i1yQegcYm8n
fMnLVVZnuHun3RmGyYXt
=sQoF
-----END PGP SIGNATURE-----

--gj572EiMnwbLXET9--