From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751379AbdE3McD (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 May 2017 08:32:03 -0400
Received: from bombadil.infradead.org ([65.50.211.133]:48380 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750902AbdE3McB (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 May 2017 08:32:01 -0400
Date: Tue, 30 May 2017 14:31:56 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 6/7] sched/rt: make it configurable
Message-ID: <20170530123156.o4flo6j6e6qu767a@hirez.programming.kicks-ass.net>
References: <20170529210302.26868-1-nicolas.pitre@linaro.org>
 <20170529210302.26868-7-nicolas.pitre@linaro.org>
 <20170530084115.chn47covtxlcktna@hirez.programming.kicks-ass.net>
 <alpine.LFD.2.20.1705300815040.17440@knanqh.ubzr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LFD.2.20.1705300815040.17440@knanqh.ubzr>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 30, 2017 at 08:17:00AM -0400, Nicolas Pitre wrote:
> On Tue, 30 May 2017, Peter Zijlstra wrote:
> 
> > On Mon, May 29, 2017 at 05:03:01PM -0400, Nicolas Pitre wrote:
> > 
> > > @@ -1303,8 +1303,17 @@ config SCHED_AUTOGROUP
> > >  	  desktop applications.  Task group autogeneration is currently based
> > >  	  upon task session.
> > >  
> > > +config SCHED_RT
> > > +	bool "Real Time Task Scheduling" if EXPERT
> > > +	default y
> > > +	help
> > > +	  This adds the sched_rt scheduling class to the kernel providing
> > > + 	  support for the SCHED_FIFO and SCHED_RR policies. You might want
> > > +	  to disable this to reduce the kernel size. If unsure say y.
> > > +
> > >  config SCHED_DL
> > >  	bool "Deadline Task Scheduling" if EXPERT
> > > +	depends on SCHED_RT
> > >  	default y
> > >  	help
> > >  	  This adds the sched_dl scheduling class to the kernel providing
> > > @@ -1632,6 +1641,7 @@ config BASE_FULL
> > >  config FUTEX
> > >  	bool "Enable futex support" if EXPERT
> > >  	default y
> > > +	depends on SCHED_RT
> > >  	select RT_MUTEXES
> > >  	help
> > >  	  Disabling this option will cause the kernel to be built without
> > 
> > Aside from all the other completely non-starter #ifdeffery trainwrecks,
> > this is just plain wrong.
> 
> Care to elaborate?

SCHED_DL does not in any way depend on SCHED_RT and futexes should not
wholly get axed when we lack SCHED_RT.

> You might not like the approach, but you can't dismiss the goal just 
> like that. So please help me do it right.

Why can't I dismiss it? All I see is ugly that makes maintenance worse
for very little to no benefit.