From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751602AbdE3NpC (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 May 2017 09:45:02 -0400
Received: from mx2.suse.de ([195.135.220.15]:44794 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1750951AbdE3No7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 May 2017 09:44:59 -0400
Date: Tue, 30 May 2017 15:44:55 +0200
From: Michal Hocko <mhocko@kernel.org>
To: Roman Gushchin <guro@fb.com>
Cc: Balbir Singh <bsingharora@gmail.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Vladimir Davydov <vdavydov.dev@gmail.com>, kernel-team@fb.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: bump PGSTEAL*/PGSCAN*/ALLOCSTALL counters in memcg
 reclaim
Message-ID: <20170530134455.GH7969@dhcp22.suse.cz>
References: <1496062901-21456-1-git-send-email-guro@fb.com>
 <20170530122436.GE7969@dhcp22.suse.cz>
 <20170530132114.GA28148@castle>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170530132114.GA28148@castle>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue 30-05-17 14:21:14, Roman Gushchin wrote:
[...]
> But what about PGSTEAL*/PGSCAN* counters, isn't it better to make them
> reflect __all__ reclaim activity, no matter what was a root cause?

What would be the advantage? Those counters have always been global and
we should better have a strong reason to change that.

-- 
Michal Hocko
SUSE Labs