mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Cosar Dindar <cosardindar@gmail.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
	mark.rutland@arm.com, mcoquelin.stm32@gmail.com,
	alexandre.torgue@st.com, linux-crypto@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, fabien.dessenne@st.com
Subject: Re: [PATCH v2 2/5] dt-bindings : Document the STM32F4 CRC32 binding
Date: Tue, 30 May 2017 17:50:24 -0500	[thread overview]
Message-ID: <20170530225024.ypguef347yqbjbsd@rob-hp-laptop> (raw)
In-Reply-To: <bb672acb88667e9d27beb4d1e4fd8882f265ee47.1495285223.git.cosardindar@gmail.com>

On Sat, May 20, 2017 at 04:32:12PM +0300, Cosar Dindar wrote:
> Add device tree binding for STM32F4.
> 
> Signed-off-by: Cosar Dindar <cosardindar@gmail.com>
> ---
>  Documentation/devicetree/bindings/crypto/st,stm32-crc.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/st,stm32-crc.txt b/Documentation/devicetree/bindings/crypto/st,stm32-crc.txt
> index 3ba92a5..7b30f1e 100644
> --- a/Documentation/devicetree/bindings/crypto/st,stm32-crc.txt
> +++ b/Documentation/devicetree/bindings/crypto/st,stm32-crc.txt
> @@ -1,7 +1,7 @@
>  * STMicroelectronics STM32 CRC
>  
>  Required properties:
> -- compatible: Should be "st,stm32f7-crc".
> +- compatible: Can be either "st,stm32f7-crc" or "st,srm32f4-crc".

Here you say either, but the example has both.

>  - reg: The address and length of the peripheral registers space
>  - clocks: The input clock of the CRC instance
>  
> @@ -10,7 +10,7 @@ Optional properties: none
>  Example:
>  
>  crc: crc@40023000 {
> -	compatible = "st,stm32f7-crc";
> +	compatible = "st,stm32f7-crc", "st,stm32f4-crc";
>  	reg = <0x40023000 0x400>;
>  	clocks = <&rcc 0 12>;
>  };
> -- 
> 2.7.4
> 

  reply	other threads:[~2017-05-30 22:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-20 13:30 [PATCH v2 0/5] Add support for the STM32F4 CRC32 Cosar Dindar
2017-05-20 13:31 ` [PATCH v2 1/5] crypto : stm32 - Add STM32F4 CRC32 support Cosar Dindar
2017-05-20 13:32 ` [PATCH v2 2/5] dt-bindings : Document the STM32F4 CRC32 binding Cosar Dindar
2017-05-30 22:50   ` Rob Herring [this message]
2017-05-31  8:17     ` Cosar Dindar
2017-05-20 13:32 ` [PATCH v2 3/5] ARM: dts: stm32: enable CRC32 on stm32429-disco board Cosar Dindar
2017-05-22 11:14   ` kbuild test robot
2017-05-20 13:33 ` [PATCH v2 4/5] ARM: dts: stm32: enable CRC32 on stm32429i-eval board Cosar Dindar
2017-05-20 13:33 ` [PATCH v2 5/5] ARM: dts: stm32: Add CRC support to stm32f429 Cosar Dindar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170530225024.ypguef347yqbjbsd@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=alexandre.torgue@st.com \
    --cc=cosardindar@gmail.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=fabien.dessenne@st.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mcoquelin.stm32@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®