From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751236AbdE3WvB (ORCPT ); Tue, 30 May 2017 18:51:01 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:34666 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172AbdE3WvA (ORCPT ); Tue, 30 May 2017 18:51:00 -0400 From: Douglas Anderson To: keescook@chromium.org Cc: Douglas Anderson , anton@enomsg.org, ccross@android.com, Tony Luck , linux-kernel@vger.kernel.org Subject: [PATCH] pstore: Fix leaked pstore_record in pstore_get_backend_records() Date: Tue, 30 May 2017 15:50:38 -0700 Message-Id: <20170530225038.21604-1-dianders@chromium.org> X-Mailer: git-send-email 2.13.0.219.gdb65acc882-goog Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the "if (record->size <= 0)" test is true in pstore_get_backend_records() it's pretty clear that nobody holds a reference to the allocated pstore_record, yet we don't free it. Let's free it. Fixes: 2a2b0acf768c ("pstore: Allocate records on heap instead of stack") Signed-off-by: Douglas Anderson --- fs/pstore/platform.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c index d468eec9b8a6..9defe98ff8b1 100644 --- a/fs/pstore/platform.c +++ b/fs/pstore/platform.c @@ -846,8 +846,10 @@ void pstore_get_backend_records(struct pstore_info *psi, record->size = psi->read(record); /* No more records left in backend? */ - if (record->size <= 0) + if (record->size <= 0) { + kfree(record); break; + } decompress_record(record); rc = pstore_mkfile(root, record); -- 2.13.0.219.gdb65acc882-goog