From: David Miller <davem@davemloft.net>
To: daniel.vetter@ffwll.ch
Cc: airlied@gmail.com, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, jani.nikula@linux.intel.com,
jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PULL] topic/e1000e-fix
Date: Wed, 31 May 2017 11:08:33 -0400 (EDT) [thread overview]
Message-ID: <20170531.110833.1362264472730468352.davem@davemloft.net> (raw)
In-Reply-To: <CAKMK7uGbi2Bwfno9XogKZ-LUOyMepbtRyGuGrNYWwj6Cts+uag@mail.gmail.com>
From: Daniel Vetter <daniel.vetter@ffwll.ch>
Date: Wed, 31 May 2017 08:10:45 +0200
> On Wed, May 31, 2017 at 7:54 AM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>> On Wed, May 31, 2017 at 1:06 AM, Dave Airlie <airlied@gmail.com> wrote:
>>> On 31 May 2017 at 08:10, David Miller <davem@davemloft.net> wrote:
>>>> From: Daniel Vetter <daniel.vetter@ffwll.ch>
>>>> Date: Tue, 30 May 2017 22:15:42 +0200
>>>>
>>>>> If the e1000e maintainer wants to coalesce or not return statements
>>>>> this simple way, that's imo on him to change the color as needed.
>>>>
>>>> That's not how things work.
>>>>
>>>> If the maintainer wants you to style things a certain way, either you
>>>> do it that way or your patch isn't accepted.
>>
>> Consider this pull a regression report, pls handle it.
>
> And I guess I pile of more cc, to make this regression report
> complete. I mean you got the backtrace, bisect and a proposed fix, and
> the almost-whitespace change demanded is something gcc does in its
> sleep. I'd understand a request to retest if it would be a real
> functional change, but in this situation I have no idea why this
> regression just can't be fixed already.
And we can't understand why respinning with the requested change is
less work than making several postings such as this one.
next prev parent reply other threads:[~2017-05-31 15:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170530201542.a5rudn6xfykbj3la@phenom.ffwll.local>
[not found] ` <20170530.181022.1101254623191993046.davem@davemloft.net>
[not found] ` <CAPM=9twH-CXm+xj2Os87Ra7nOBQ+WNXYGF83wFqpQ3s=MNx_mQ@mail.gmail.com>
[not found] ` <CAKMK7uF-b1U7qipgEoYnAjDtrNdvKYT4KkoV2=krikkdGERkCw@mail.gmail.com>
2017-05-31 6:10 ` Daniel Vetter
2017-05-31 15:08 ` David Miller [this message]
2017-05-31 15:50 ` Jani Nikula
2017-05-31 15:50 ` [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails Jani Nikula
2017-06-02 18:14 ` David Miller
2017-06-06 20:46 ` Jeff Kirsher
2017-06-07 1:07 ` [Intel-wired-lan] " Brown, Aaron F
2017-06-20 8:49 ` Daniel Vetter
2017-06-27 19:28 ` Dave Airlie
2017-06-27 20:51 ` Jeff Kirsher
2017-06-28 5:35 ` Daniel Vetter
2017-06-05 5:20 ` Neftin, Sasha
2017-05-31 16:23 ` [PULL] topic/e1000e-fix Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531.110833.1362264472730468352.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=airlied@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jani.nikula@linux.intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®