From: David Miller <davem@davemloft.net>
To: andy.shevchenko@gmail.com
Cc: jan.kiszka@siemens.com, peppe.cavallaro@st.com,
alexandre.torgue@st.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/6] stmmac: pci: Refactor DMI probing
Date: Wed, 31 May 2017 12:32:02 -0400 (EDT) [thread overview]
Message-ID: <20170531.123202.240107293094153046.davem@davemloft.net> (raw)
In-Reply-To: <CAHp75VcGNr78mfGgtrKuZJtLppv=rAJ4Bxejcec3MhnC6ejSjQ@mail.gmail.com>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Tue, 30 May 2017 21:48:05 +0300
> On Tue, May 30, 2017 at 10:33 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> Some cleanups of the way we probe DMI platforms in the driver. Reduces
>> a bit of open-coding and makes the logic easier reusable for any
>> potential DMI platform != Quark.
>>
>> Tested on IOT2000 and Galileo Gen2.
>
> So, for patches 1-4,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> I'm not convinced that patch 6 is needed, so, my vote is not to include it.
>
> Patch 5 I would like to review later. Main problem to me is {-1, -1}.
> It looks non-standard and feels not good. I'll try to think on the
> solution.
Ok, so at a minimum I'm expecting another respin of this.
prev parent reply other threads:[~2017-05-31 16:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 7:33 Jan Kiszka
2017-05-30 7:33 ` [PATCH v3 1/6] stmmac: pci: Make stmmac_pci_info structure constant Jan Kiszka
2017-05-30 7:33 ` [PATCH v3 2/6] stmmac: pci: Use stmmac_pci_info for all devices Jan Kiszka
2017-05-30 7:33 ` [PATCH v3 3/6] stmmac: pci: Make stmmac_pci_find_phy_addr truly generic Jan Kiszka
2017-05-30 7:33 ` [PATCH v3 4/6] stmmac: pci: Select quark_pci_dmi_data from quark_default_data Jan Kiszka
2017-05-30 7:33 ` [PATCH v3 5/6] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses Jan Kiszka
2017-05-31 18:09 ` Andy Shevchenko
2017-05-30 7:33 ` [PATCH v3 6/6] stmmac: pci: Remove setup handler indirection via stmmac_pci_info Jan Kiszka
2017-05-30 18:48 ` [PATCH v3 0/6] stmmac: pci: Refactor DMI probing Andy Shevchenko
2017-05-31 16:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531.123202.240107293094153046.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=andy.shevchenko@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®