From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751116AbdEaQxf (ORCPT ); Wed, 31 May 2017 12:53:35 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:41054 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750912AbdEaQxe (ORCPT ); Wed, 31 May 2017 12:53:34 -0400 Date: Wed, 31 May 2017 12:53:32 -0400 (EDT) Message-Id: <20170531.125332.804150363431702680.davem@davemloft.net> To: arnd@arndb.de Cc: yotamg@mellanox.com, idosch@mellanox.com, jiri@mellanox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net/mlxfw: select CONFIG_XZ_DEC From: David Miller In-Reply-To: <20170530092628.1306028-1-arnd@arndb.de> References: <20170530092628.1306028-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 31 May 2017 09:11:57 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Tue, 30 May 2017 11:26:14 +0200 > The new mlxfw code fails to build without the xz library: > > drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.o: In function `mlxfw_mfa2_xz_dec_run': > :(.text.mlxfw_mfa2_xz_dec_run+0x8): undefined reference to `xz_dec_run' > drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.o: In function `mlxfw_mfa2_file_component_get': > :(.text.mlxfw_mfa2_file_component_get+0x218): undefined reference to `xz_dec_init' > :(.text.mlxfw_mfa2_file_component_get+0x2c0): undefined reference to `xz_dec_end' > > This adds a Kconfig 'select' statement for it, which is also what > the other user of that library has. > > Fixes: 410ed13cae39 ("Add the mlxfw module for Mellanox firmware flash process") > Signed-off-by: Arnd Bergmann Applied, thanks Arnd.